docs: Internals Book improvements (08) - #23375
Draft
NickSdot wants to merge 22 commits into
Draft
Conversation
- replaced obsolete prototypes and external MySQL example with current stream contracts
- removed zend_parse_parameter() which was removed on 2026-08-10 (see UPGRADING.INTERNALS). - corrected variadic argument ownership/types.
- removed obsolete php 5 build system - corrected PHP_NEW_EXTENSION signature and C++ setup
- replaced obsolete PHP 5 example with the current SAPI callback contract - rewrote things
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: ##23368 (01), #23369 (02), #23370 (03), #23371 (04), #23372 (05), #23373 (06), #23374 (07)
The "Writing Tests" page was 1:1 moved from QA in #18409. It is too large for a single page; hard to navigate and the sidebar navigation bloated. Separating sections and samples (and later more) makes it much easier to navigate and digest. Diff to 07: NickSdot/php__php-src@docs/restructure-07...docs/restructure-08
Note:
This change is the reason why I started improving the Internals Book in the first place. As some already noticed, I am trying to make myself helpful with testing and QA related stuff. The testing docs are dated, incomplete, and not exactly easy to digest. This change allows me to improve the testing docs in a growable structure as I go over the next weeks. Think of: coverage docs, updating examples and samples, general refresh and formatting, adding requirements, etc. etc. So this is not the "final" or perfect state, but the foundation for what comes, and already a step forward to what we have now. 🫡
Preview
(both same, unless another branch/PR after 08 will added)
Branch: https://nicksdot.github.io/docs-restructure-08/
Final: https://nicksdot.github.io/docs-restructure-final/
Aside
Unless a discussions in any of the PRs require to add another follow up PR to make the chain mergable this is the last PR of this series. Everything else can be normal PRs that do not depends on previews changes.