Skip to content

Zend: remove some unused portability macros - #24279

Merged
Girgias merged 2 commits into
php:masterfrom
Girgias:2026-10-old-portability-macros
Oct 12, 2026
Merged

Girgias merged 2 commits into
php:masterfrom
Girgias:2026-10-old-portability-macros

Conversation

@Girgias

@Girgias Girgias commented Oct 12, 2026

Copy link
Copy Markdown
Member

No description provided.

@LamentXU123 LamentXU123 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the usage of ((x) ? 1 : 0) anyways...?
If we really need a logic xor, it's fine to re-write it as !!(x) != !!(y) I suppose. But yeah since no one use this anymore just remove them

@Girgias
Girgias merged commit 8db886e into php:master Oct 12, 2026
18 checks passed
@Girgias
Girgias deleted the 2026-10-old-portability-macros branch October 12, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants