Fix filter_var throw-on-failure detection#6042
Merged
staabm merged 1 commit intoJul 13, 2026
Merged
Conversation
Collaborator
|
This pull request has been marked as ready for review. |
staabm
reviewed
Jul 12, 2026
| ): ?Type | ||
| { | ||
| if (!isset($funcCall->getArgs()[3])) { | ||
| if (!isset($funcCall->getArgs()[2])) { |
Contributor
VincentLanglet
approved these changes
Jul 12, 2026
staabm
approved these changes
Jul 13, 2026
Contributor
|
thank you @simPod |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
filter_var()accepts options and flags in its third argument.FilterVarThrowTypeExtensionwas reading the fourth argument instead, so valid calls like this were not treated as throwing:That made
catch (Filter\FilterFailedException)look dead even though the return type helper already narrowed the return type correctly.Fix
Read the third argument in
FilterVarThrowTypeExtensionand reuseFilterFunctionReturnTypeHelper::hasFlag().This keeps throw detection consistent for both forms: