Reset expression analysis state in ExpressionResultTest - #6254
Open
simPod wants to merge 1 commit into
Open
Conversation
simPod
marked this pull request as ready for review
August 24, 2026 13:44
Collaborator
|
This pull request has been marked as ready for review. |
simPod
force-pushed
the
test/reset-expression-analysis-state
branch
from
August 24, 2026 14:19
4868219 to
c975247
Compare
simPod
force-pushed
the
test/reset-expression-analysis-state
branch
from
August 24, 2026 14:34
c975247 to
617d53d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExpressionResultTestcallsNodeScopeResolver::processExprNode()directly for multiple data-provider cases. Unlike normal file analysis, this path did not reset per-file resolver state first.Cached closure types can therefore survive between cases and be read again when PHP reuses a
spl_object_id(). Reset the resolver before each direct expression analysis so the test follows the normal per-file lifecycle and does not depend on test order.