Repository navigation
Test the non-parse exception that stops the result cache save with a rule - #6729
Merged
ondrejmirtes merged 1 commit intoOct 23, 2026
Merged
Conversation
…rule Since the BetterReflection update in 613b1b1, a class that extends itself is no longer a reflection error, so the last part of the result-cache-parse-error e2e test failed. A rule that throws ClassNotFoundException now tests the same branch of the save, in the result-cache-internal-error fixture. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
SanderMuller
force-pushed
the
result-cache-parse-error-e2e
branch
from
October 23, 2026 19:59
c8e8ec2 to
0e38edf
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
result-cache-parse-errore2e job fails on 2.3.x, for example in this run on f064084. It passed on 28f54de and has failed since the next commit, the BetterReflection update in 613b1b1.Its last part copies in a class that extends itself and expects
Result cache was not saved because of non-ignorable exception: Reflection error: Circular reference. That update brings in ondrejmirtes/BetterReflection@34da89e, which gives a class on an inheritance cycle no parent instead of throwingCircularReference. PHPStan now reports nothing for that class, so the run exits with 0 and the step fails.That part tested one branch of the save from #6694: an exception other than a parse error still stops the save. This PR tests the same branch with a rule that throws
ClassNotFoundException, in theresult-cache-internal-errorfixture, which already loads its own rule. It removes the cycle part andloop/Loop.phpfrom the parse-error fixture.I ran both steps locally as the workflow runs them. On 2.3.x the parse-error step fails with exit code 0. On this branch both steps pass. To check that the new part tests that branch, I changed the condition so that every exception is handled like a parse error. The step then failed on the new assertion, because the result cache was saved.
#6712, which reports inheritance cycles with a rule, also changes the cycle part of this step. If this PR is merged first, I will rebase #6712 on it.
🤖 Generated with Claude Code