chore(go): upgrade Go toolchain to 1.27.1 - #1277
Merged
Merged
Conversation
Bumps the Go version used to build clients/cli and clients/go (via the go.mod.mustache template) from 1.24.4 to the latest stable release, updates the corresponding CI workflow pins, and refreshes golang.org/x/* transitive deps (oauth2, sys, text) for the CLI module. Also fixes a pre-existing go vet failure in clients/go/config_test.go (%q used on an int arg) that was blocking `go test` on main regardless of Go version. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
API changelog (oasdiff)Doc-only edits (descriptions, examples) do not appear here. |
clients/go is a published SDK consumed by external projects, unlike clients/cli which is our own build. Requiring go 1.27.1 there would be a breaking minimum-version bump for any consumer on an older toolchain. go 1.21 keeps module graph pruning and GOTOOLCHAIN support while staying broadly compatible; the CI/build toolchain (1.27.1) is unaffected since that's a floor, not a pin. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Leftover from unrelated local state, not part of this Go upgrade. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Efe Bikmaz (bikmazefe)
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clients/cli(and CI itself) from 1.24.4 to the latest stable release, 1.27.1godirective inopenapi-generator/templates/go/go.mod.mustache(and the generatedclients/go/go.mod) togo 1.21— deliberately not 1.27.1:clients/gois a published SDK consumed by external projects, so requiring 1.27.1 there would force a breaking minimum-version bump on any consumer using an older Go toolchain.go 1.21still gets module graph pruning andGOTOOLCHAINsupport while staying broadly compatible; the actual build/CI toolchain (1.27.1) is unaffected by this, sincego.mod's directive is a floor, not a pin..tool-versionsand the relevant CI workflows (build.yml,lint.yml,test-cli.yml,test-go.yml) to 1.27.1golang.org/x/*transitive deps for the CLI module (oauth2,sys,text)go vetfailure inclients/go/config_test.go(%qused on anintarg) that was silently failinggo test ./...onmainregardless of Go versionTest plan
clients/go:go build ./...andgo test ./...pass under Go 1.27.1 with thego 1.21directiveclients/cli:go mod tidy,go build ., andgo test ./...pass under Go 1.27.1config_test.govet failure pre-existed onmainunder both Go 1.24.4 and 1.27.1 (unrelated to this bump)🤖 Generated with Claude Code