Skip to content

docs: fix sync-diff-inspector limitations in migration tools - #21937

Open
doc-claw-bot wants to merge 1 commit into
pingcap:release-8.5from
doc-claw-bot:docs/sync-diff-migration-tools-8.5
Open

doc-claw-bot wants to merge 1 commit into
pingcap:release-8.5from
doc-claw-bot:docs/sync-diff-migration-tools-8.5

Conversation

@doc-claw-bot

@doc-claw-bot doc-claw-bot commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

What is changed, added or deleted? (Required)

This PR updates the sync-diff-inspector row in migration-tools.md on release-8.5 to match the detailed stable documentation.

  • Remove the incorrect statement that JSON, BIT, BINARY, and BLOB data are unsupported.
  • Clarify that JSON, BLOB/VARBINARY, and BIT are supported.
  • Point readers to the detailed restrictions page for FLOAT/DOUBLE and collation-related considerations.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • 文档
    • 更新 sync-diff-inspector 的数据类型支持说明。
    • 明确 JSON、BLOB/VARBINARY 和 BIT 类型受支持。
    • 补充 FLOAT/DOUBLE 及排序规则相关注意事项,并引导查阅使用限制文档。

@ti-chi-bot

ti-chi-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tomshawn for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 16, 2026
@doc-claw-bot doc-claw-bot added type/bugfix This PR fixes a bug. translation/from-docs This PR is translated from a PR in pingcap/docs. needs-cherry-pick-master Should cherry pick this PR to master branch. labels Sep 16, 2026
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

📝 Walkthrough

Walkthrough

Changes

sync-diff-inspector 文档更新

Layer / File(s) Summary
更新数据类型支持说明
migration-tools.md
将“不支持 JSON、BIT、BINARY、BLOB 等类型”的说明更新为分类描述。文档明确 JSON、BLOB/VARBINARY 和 BIT 类型受支持,并指向 FLOAT/DOUBLE 及排序规则的使用限制文档。

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: 🔵 Low · up to 4c717

The documentation may cause users to overestimate type support and misinterpret narrow JSON or BIT comparison cases.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed 标题准确概括了主要变更,即修正文档中的 sync-diff-inspector 使用限制说明。标题简洁且具体。
Description check ✅ Passed 描述说明了变更内容、适用版本、相关链接、AI 参与情况及其他检查项。必需信息基本完整,且与 PR 目标一致。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Sep 16, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 53d25b64-684b-4499-b5e3-70c24ee4c7a1

📥 Commits

Reviewing files that changed from the base of the PR and between 25a2849 and 4c7175d.

📒 Files selected for processing (1)
  • migration-tools.md

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Comment thread migration-tools.md
| **下游** | TiDB,MySQL |
| **主要优势** | 提供了修复数据的功能,适用于修复少量不一致的数据。|
| **使用限制** | <ul><li>对于 MySQL 和 TiDB 之间的数据同步不支持在线校验。</li><li>不支持 JSON、BIT、BINARY、BLOB 等类型的数据。</li></ul> |
| **使用限制** | <ul><li>对于 MySQL 和 TiDB 之间的数据同步不支持在线校验。</li><li>不同数据类型的支持情况有所不同。JSON、BLOB/VARBINARY 和 BIT 类型受支持;关于 FLOAT/DOUBLE 和排序规则相关注意事项,请参见 <a href="/sync-diff-inspector/sync-diff-inspector-overview.md">sync-diff-inspector 的使用限制</a>。</li></ul> |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🔎 Supported by static analysis

🏁 Script executed:

sed -n '45,70p' sync-diff-inspector/sync-diff-inspector-overview.md
git diff -- migration-tools.md
rg -n 'BIT|JSON|字符集|排序规则|collation|charset' sync-diff-inspector migration-tools.md

Repository: pingcap/docs-cn

Length of output: 2889


补充 BIT 位宽和 JSON 字符集限制。

使用限制文档仅说明已验证 BIT 位宽为 1、8、16 和 64。当前摘要会让用户误以为所有 BIT 类型均已验证支持。该文档还指出,JSON 字符串值可能因排序规则和字符集差异产生误报。

Suggested change
| **使用限制** | <ul><li>对于 MySQL 和 TiDB 之间的数据同步不支持在线校验。</li><li>不同数据类型的支持情况有所不同。JSONBLOB/VARBINARY BIT 类型受支持;关于 FLOAT/DOUBLE 和排序规则相关注意事项,请参见 <a href="/sync-diff-inspector/sync-diff-inspector-overview.md">sync-diff-inspector 的使用限制</a>。</li></ul> |
| **使用限制** | <ul><li>对于 MySQL 和 TiDB 之间的数据同步不支持在线校验。</li><li>不同数据类型的支持情况有所不同。JSON 支持比较,但上下游之间 JSON 字符串值的排序规则和字符集差异可能导致误报数据不一致;BLOB/VARBINARY 支持比较,按二进制数据逐字节进行校验;BIT 支持 MySQL 与 TiDB 之间的数据比较,已验证支持位宽为 1、8、16 和 64 的 BIT 类型。对于非标准位宽或应用层转换场景,请先进行针对性的验证测试;关于 FLOAT/DOUBLE 的注意事项,请参见 <a href="/sync-diff-inspector/sync-diff-inspector-overview.md">sync-diff-inspector 的使用限制</a>。</li></ul> |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. needs-cherry-pick-master Should cherry pick this PR to master branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant