Skip to content

i18n-ja-release-8.5: Vale PingCAP.ZhPunctuation reports every Japanese full stop as an error #24533

Open

Description

@yahonda

Problem

On the i18n-ja-release-8.5 branch, the Vale rule PingCAP.ZhPunctuation reports every Japanese full stop 「。」 as an error:

[PingCAP.ZhPunctuation] Don't use Chinese punctuation (。) in English text.

The Japanese docs use 「。」, 「、」, and 「」 as correct Japanese punctuation, so every Japanese pull request gets a large number of false errors:

The vale check itself passes, so these errors do not block merging. They only add noise to Japanese reviews.

Cause

  • .vale.ini applies the PingCAP style to every Markdown file ([*.md] → BasedOnStyles = PingCAP). The i18n-ja-release-8.5 branch uses the same file.
  • styles/PingCAP/ZhPunctuation.yml matches !|?|,|。|:|;|“|”|’|‘ with no language or path condition. Its message says "in English text", but on the Japanese branch every file is Japanese text.

Suggested fix

On the i18n-ja-* branches only, turn off the rules that are meant for English text. For example, in .vale.ini on i18n-ja-release-8.5:

[*.md]
BasedOnStyles = PingCAP
Vale.Avoid = YES
PingCAP.ZhPunctuation = NO

Other PingCAP rules are written for English as well, such as Spacing, HeadingPunctuation, and OptionalPlurals, and might need the same treatment. The English branches (master, release-*) should keep ZhPunctuation, because there it catches real Chinese punctuation in English text.

Affected branch

  • i18n-ja-release-8.5

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions