You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
i18n-ja-release-8.5: Vale PingCAP.ZhPunctuation reports every Japanese full stop as an error #24533
The vale check itself passes, so these errors do not block merging. They only add noise to Japanese reviews.
Cause
.vale.ini applies the PingCAP style to every Markdown file ([*.md] → BasedOnStyles = PingCAP). The i18n-ja-release-8.5 branch uses the same file.
styles/PingCAP/ZhPunctuation.yml matches !|?|,|。|:|;|“|”|’|‘ with no language or path condition. Its message says "in English text", but on the Japanese branch every file is Japanese text.
Suggested fix
On the i18n-ja-* branches only, turn off the rules that are meant for English text. For example, in .vale.ini on i18n-ja-release-8.5:
[*.md]BasedOnStyles = PingCAP
Vale.Avoid = YES
PingCAP.ZhPunctuation = NO
Other PingCAP rules are written for English as well, such as Spacing, HeadingPunctuation, and OptionalPlurals, and might need the same treatment. The English branches (master, release-*) should keep ZhPunctuation, because there it catches real Chinese punctuation in English text.
Activity