Conversation
Signed-off-by: wk989898 <nhsmwk@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
missing-translation-status
📝 WalkthroughWalkthroughThe documentation adds Debezium JSON handling modes for decimal, unsigned bigint, and binary values. It documents changefeed and sink URI configuration, precedence, defaults, supported options, encoding effects, and related data type mappings. ChangesDebezium handling modes
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: 🔵 Low · up to The new guidance could confuse users about which protocol receives these settings, but the issue is localized to documentation and does not affect runtime behavior. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: pingcap/docs/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: c9c75f90-b30b-4988-a64a-d73005caa91a
📒 Files selected for processing (3)
ticdc/ticdc-changefeed-config.mdticdc/ticdc-debezium.mdticdc/ticdc-sink-to-kafka.md
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
|
|
||
| ### Numeric and binary handling | ||
|
|
||
| For Debezium JSON (`protocol=debezium`), you can configure how TiCDC encodes decimal values, unsigned BIGINT values, and binary data. Set the following options in the [`[sink.debezium]`](/ticdc/ticdc-changefeed-config.md#sinkdebezium) section of the changefeed configuration file or use the corresponding `sink-uri` parameters. If you set an option in both places, the `sink-uri` value takes precedence. These options do not apply to `protocol=debezium-avro`. |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n -S \
'debezium-avro|protocol\s*[:=].*(avro|debezium)|Protocol.*(Avro|Debezium)' \
--glob '*.go' --glob '*.md' .Repository: pingcap/docs
Length of output: 7178
🏁 Script executed:
set -euo pipefail
printf '%s\n' '--- ticdc/ticdc-changefeed-config.md ---'
sed -n '188,205p' ticdc/ticdc-changefeed-config.md
printf '%s\n' '--- ticdc/ticdc-sink-to-kafka.md ---'
sed -n '68,84p' ticdc/ticdc-sink-to-kafka.md
printf '%s\n' '--- ticdc/ticdc-debezium.md ---'
sed -n '28,40p' ticdc/ticdc-debezium.mdRepository: pingcap/docs
Length of output: 6134
Use the supported Avro protocol identifier. The supported value is protocol=avro, not protocol=debezium-avro.
| For Debezium JSON (`protocol=debezium`), you can configure how TiCDC encodes decimal values, unsigned BIGINT values, and binary data. Set the following options in the [`[sink.debezium]`](/ticdc/ticdc-changefeed-config.md#sinkdebezium) section of the changefeed configuration file or use the corresponding `sink-uri` parameters. If you set an option in both places, the `sink-uri` value takes precedence. These options do not apply to `protocol=debezium-avro`. | |
| For Debezium JSON (`protocol=debezium`), you can configure how TiCDC encodes decimal values, unsigned BIGINT values, and binary data. Set the following options in the [`[sink.debezium]`](/ticdc/ticdc-changefeed-config.md#sinkdebezium) section of the changefeed configuration file or use the corresponding `sink-uri` parameters. If you set an option in both places, the `sink-uri` value takes precedence. These options do not apply to `protocol=avro`. |
Source: MCP tools
1 participant
First-time contributors' checklist
What is changed, added, or deleted? (Required)
Add the "Numeric and binary handling" section for debezium protocol
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit