Repository navigation
docs: fix wording that causes mistranslation in the Japanese docs - #24491
ti-chi-bot[bot] merged 4 commits into
Conversation
- system-variables.md: describe tidb_enable_resource_control with the
usual "controls whether to enable" instead of "is a switch for", which
was translated literally as スイッチ.
- tidb-cloud/csv-config-for-import-data.md: drop the dangling "as
follows" (what follows is the source data example, not a setting) and
the "then ... But" construction.
- develop/java-app-best-practices.md and dev-guide-connection-parameters.md:
join the sentence that was split across a code block ("If you change
the three statements into the following ones: [code] Then they meet the
rewrite requirement.").
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
📝 Walkthrough
Merge Risk: 🔵 Low · up to
|
…reshold Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: pingcap/docs/.coderabbit.yaml
- Review profile: ASSERTIVE
- Plan: Advanced
- Run ID:
894e23b0-55b1-4499-964d-c2b9c47abef5
📒 Files selected for processing: 4
develop/dev-guide-connection-parameters.mddevelop/java-app-best-practices.mdsystem-variables.mdtidb-cloud/csv-config-for-import-data.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
…cing Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ackslash escape example Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
What is changed, added, or deleted? (Required)
Fix six English wording issues that make the Japanese translation wrong or awkward. The Japanese docs are machine-translated from these English lines, so fixing the English is the way to fix the Japanese.
system-variables.md(tidb_enable_resource_control)tidb-cloud/csv-config-for-import-data.mdBackslash escape = Trueas follows. But this is not the standard format for CSV."Backslash escape = True. Note that this is not the standard format for CSV." (the previous sentence is about a JSON field, not the whole file) What follows is the source data example, not a setting, so the second "as follows" dangles.Backslash escape = Trueを設定することを検討してください」 ("as follows" twice)develop/java-app-best-practices.md,develop/dev-guide-connection-parameters.mdsystem-variables.md(tidb_opt_join_reorder_threshold)tidb-scheduling.mdtidb-scheduling.mdWhich TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
🤖 Generated with Claude Code
Summary by CodeRabbit
INSERT ... ON DUPLICATE KEY UPDATErewrite requirements and examples.