Skip to content

tidb-cloud: fix code fences, duplicated text, and wrong values in TiDB Cloud docs (#24487) - #24561

Open
ti-chi-bot wants to merge 1 commit into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-24487-to-release-8.5
Open

ti-chi-bot wants to merge 1 commit into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-24487-to-release-8.5

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #24487

What is changed, added, or deleted? (Required)

Fix code fences, duplicated text, and wrong values in the TiDB Cloud docs. These errors were found while reviewing the English docs for issues that affect the Japanese translation. Each fix is shown below; the same wrong text was also searched for in the rest of the docs.

File Before After
tidb-cloud/dedicated-external-storage.md A JSON code block opens with 4 backticks and closes with 3 Open it with 3 backticks
releases/release-7.6.0.md A SQL code block opens with 3 backticks and closes with 4 Close it with 3 backticks
tidb-cloud/set-up-private-endpoint-connections.md "Go to VPC > Endpoints. To do so, go to VPC > Endpoints, …" Remove the duplicated first sentence
tidb-cloud/sql-concepts.md The "Since the value of AUTO_RANDOM is random and unique, …" sentence appears twice in a row Keep it once
tidb-cloud/terraform-get-tidbcloud-provider.md The example for "By setting sync to true" does not set sync Add sync = true
tidb-cloud/serverless-private-link-connection-to-self-hosted-kafka-in-alicloud.md, …-in-aws.md, setup-aws-self-hosted-kafka-private-link-service.md The comment says "b2.…:9095" while the configuration line below it is for b3 "b3.…:9095"
tidb-cloud/use-chat2query-api.md HTTP method DEL DELETE
tidb-cloud/migrate-from-op-tidb.md After SET GLOBAL tidb_gc_enable = TRUE, "1 indicates that GC is disabled" "enabled"
tidb-cloud/tidb-cloud-password-authentication.md Note: "Google SSO or GitHub SSO … managed by Google or GitHub" Include Microsoft, as in the rest of the page

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

  • Related code change PR links (if applicable):
  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Added a guide to the Chat2Query API, covering availability, setup, endpoint selection, request examples, usage limits, and version-specific workflows.
    • Corrected guidance on GC status, SSO password management, and private endpoint security groups.
    • Updated Kafka private-link examples to use the matching broker ID, and clarified SQL and Terraform configuration examples.

Signed-off-by: ti-chi-bot <ci@pingcap.com>
@ti-chi-bot ti-chi-bot added lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Oct 27, 2026
@ti-chi-bot

ti-chi-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oreoxmt for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2026
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Walkthrough

The change adds a Chat2Query API guide with endpoint workflows and examples. It also corrects examples, instructions, and descriptions in existing release and TiDB Cloud documentation.

Changes: Chat2Query API guide

Layer / File(s) Summary
Access and endpoint overview
tidb-cloud/use-chat2query-api.md
The guide describes API availability, Data App and API-key setup, request limits, and v3, v2, and deprecated v1 endpoints.
Data-summary workflow
tidb-cloud/use-chat2query-api.md
The guide covers v3 data-summary creation, reuse, and asynchronous job polling.
Chat2Query v3 requests
tidb-cloud/use-chat2query-api.md
The guide documents v3 request parameters, SQL-generation modes, response examples, and asynchronous job retrieval.
Deprecated v1 endpoint
tidb-cloud/use-chat2query-api.md
The guide documents v1 restrictions, request parameters, examples, and related documentation links.

Existing documentation updates

Layer / File(s) Summary
Example values and configuration
tidb-cloud/migrate-from-op-tidb.md, tidb-cloud/serverless-private-link-connection-to-self-hosted-kafka-in-alicloud.md, tidb-cloud/serverless-private-link-connection-to-self-hosted-kafka-in-aws.md, tidb-cloud/setup-aws-self-hosted-kafka-private-link-service.md, tidb-cloud/terraform-get-tidbcloud-provider.md
Examples correct the meaning of GC output 1, use broker ID b3 for the listed AZ3 listeners, and add sync = true to the Terraform provider configuration.
Instructions and descriptions
tidb-cloud/set-up-private-endpoint-connections.md, tidb-cloud/tidb-cloud-password-authentication.md, tidb-cloud/sql-concepts.md
The documentation updates endpoint security-group instructions, adds Microsoft SSO to the password guidance, and shortens the AUTO_RANDOM description.
Markdown code fences
releases/release-7.6.0.md, tidb-cloud/dedicated-external-storage.md
The SQL example’s closing fence and the S3 policy example’s opening fence use three backticks.

Priority: Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Possibly related PRs

Suggested labels: area/tidb-cloud, size/L, type/cherry-pick-for-release-8.5

Suggested reviewers: qiancai, shiyuhang0, wildpcww

Merge Risk: Low · up to cd699

This documentation change fixes several existing errors and adds a Chat2Query API guide. The guide's job-status curl example contains a stray backtick that breaks the copied command. Its polling instructions and response example also have small inaccuracies. These are quick documentation edits and do not affect product behavior, so fix them before or soon after merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title names the main change: fixing code fences, duplicated text, and wrong values in TiDB Cloud docs. The changeset contains exactly these kinds of fixes across the listed files. The title is spe…
Description check Passed The description follows the template. It states what changed in a table with before and after entries for each file. It marks the affected versions (master and v8.5). It fills in the AI agent involvem…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: fixing code fences, duplicated text, and wrong values in TiDB Cloud docs. The changeset contains exactly these kinds of fixes across the listed files. The title is specific enough for a reviewer scanning history, although it is slightly long at 90 characters.

Full details: Description check

Explanation

The description follows the template. It states what changed in a table with before and after entries for each file. It marks the affected versions (master and v8.5). It fills in the AI agent involvement checkbox and the cherry-pick source. The contributor checklist and related-PR links are left unfilled. These are non-critical for an automated cherry-pick, so the description is mostly complete.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (11 skipped: 11 unsupported.)

Finishing Touches: 💡 1
🧪 Generate unit tests (beta)
  • Create a new PR
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 7


Review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 636d630 and cd6998f.

Files selected for processing: 11
  • releases/release-7.6.0.md
  • tidb-cloud/dedicated-external-storage.md
  • tidb-cloud/migrate-from-op-tidb.md
  • tidb-cloud/serverless-private-link-connection-to-self-hosted-kafka-in-alicloud.md
  • tidb-cloud/serverless-private-link-connection-to-self-hosted-kafka-in-aws.md
  • tidb-cloud/set-up-private-endpoint-connections.md
  • tidb-cloud/setup-aws-self-hosted-kafka-private-link-service.md
  • tidb-cloud/sql-concepts.md
  • tidb-cloud/terraform-get-tidbcloud-provider.md
  • tidb-cloud/tidb-cloud-password-authentication.md
  • tidb-cloud/use-chat2query-api.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Comment on lines +72 to +73
- Chat2Query v3 endpoints: the endpoints whose names starting with `/v3`, such as `/v3/dataSummaries` and `/v3/chat2data`(recommended)
- Chat2Query v2 endpoints: the endpoints whose names starting with `/v2`, such as `/v2/dataSummaries` and `/v2/chat2data`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Maintainability & Code Quality · Quick win

Correct the endpoint-list grammar.

Use start with instead of starting with. Add a space before (recommended).

Suggested replacement
--- "a/tidb-cloud/use-chat2query-api.md"
+++ "b/tidb-cloud/use-chat2query-api.md"
@@ -69,8 +69,8 @@
 
 In each Chat2Query Data App, you can find the following endpoints:
 
-- Chat2Query v3 endpoints: the endpoints whose names starting with `/v3`, such as `/v3/dataSummaries` and `/v3/chat2data`(recommended)
-- Chat2Query v2 endpoints: the endpoints whose names starting with `/v2`, such as `/v2/dataSummaries` and `/v2/chat2data`
+- Chat2Query v3 endpoints: the endpoints whose names start with `/v3`, such as `/v3/dataSummaries` and `/v3/chat2data` (recommended)
+- Chat2Query v2 endpoints: the endpoints whose names start with `/v2`, such as `/v2/dataSummaries` and `/v2/chat2data`
 - Chat2Query v1 endpoint: `/v1/chat2data`(deprecated)
 
 > **Tip:**

As per path instructions, this is an exact replacement for contiguous Markdown lines.

Committable suggestion

IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- Chat2Query v3 endpoints: the endpoints whose names starting with `/v3`, such as `/v3/dataSummaries` and `/v3/chat2data`(recommended)
- Chat2Query v2 endpoints: the endpoints whose names starting with `/v2`, such as `/v2/dataSummaries` and `/v2/chat2data`
- Chat2Query v3 endpoints: the endpoints whose names start with `/v3`, such as `/v3/dataSummaries` and `/v3/chat2data` (recommended)
- Chat2Query v2 endpoints: the endpoints whose names start with `/v2`, such as `/v2/dataSummaries` and `/v2/chat2data`

Source: Path instructions


> **Tip:**
>
> Compared with `/v1/chat2data`, `/v3/chat2data` and `/v2/chat2data` requires you to analyze your database first by calling `/v3/dataSummaries` or `/v2/dataSummaries`. Consequently, the results returned by `/v3/chat2data` and `/v2/chat2data` are generally more accurate.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Maintainability & Code Quality · Quick win

Fix the plural agreement in the endpoint comparison.

/v3/chat2data and /v2/chat2data are plural, so use require instead of requires.

Suggested replacement
-Compared with `/v1/chat2data`, `/v3/chat2data` and `/v2/chat2data` requires you to analyze your database first by calling `/v3/dataSummaries` or `/v2/dataSummaries`. Consequently, the results returned by `/v3/chat2data` and `/v2/chat2data` are generally more accurate.
+Compared with `/v1/chat2data`, `/v3/chat2data` and `/v2/chat2data` require you to analyze your database first by calling `/v3/dataSummaries` or `/v2/dataSummaries`. Consequently, the results returned by `/v3/chat2data` and `/v2/chat2data` are generally more accurate.

As per path instructions, this is an exact replacement for the contiguous Markdown line.

Source: Path instructions

| PUT | `/v3/dataSummaries/{data_summary_id}` | This endpoint updates a specific data summary. |
| PUT | `/v3/dataSummaries/{data_summary_id}/tables/{table_name}` | This endpoint updates the description of a specific table in a specific data summary. |
| PUT | `/v3/dataSummaries/{data_summary_id}/tables/{table_name}/columns` | This endpoint updates the description of columns for a specific table in a specific data summary. |
| POST | `/v3/knowledgeBases` | This endpoint creates a new knowledge base. For more information about the usage of knowledge base related endpoints, see [Use knowledge bases](/tidb-cloud/use-chat2query-knowledge.md). |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Maintainability & Code Quality · Quick win

Hyphenate the compound adjective.

Use knowledge-base-related before endpoints.

Suggested replacement
--- "a/tidb-cloud/use-chat2query-api.md"
+++ "b/tidb-cloud/use-chat2query-api.md"
@@ -107,7 +107,7 @@
 | PUT    | `/v3/dataSummaries/{data_summary_id}` | This endpoint updates a specific data summary. |
 | PUT    | `/v3/dataSummaries/{data_summary_id}/tables/{table_name}` | This endpoint updates the description of a specific table in a specific data summary. |
 | PUT    | `/v3/dataSummaries/{data_summary_id}/tables/{table_name}/columns` | This endpoint updates the description of columns for a specific table in a specific data summary. |
-| POST   | `/v3/knowledgeBases` | This endpoint creates a new knowledge base. For more information about the usage of knowledge base related endpoints, see [Use knowledge bases](/tidb-cloud/use-chat2query-knowledge.md).  |
+| POST   | `/v3/knowledgeBases` | This endpoint creates a new knowledge base. For more information about the usage of knowledge-base-related endpoints, see [Use knowledge bases](/tidb-cloud/use-chat2query-knowledge.md). |
 | GET    | `/v3/knowledgeBases` | This endpoint retrieves all knowledge bases. |
 | GET    | `/v3/knowledgeBases/{knowledge_base_id}` | This endpoint retrieves a specific knowledge base. |
 | PUT    | `/v3/knowledgeBases/{knowledge_base_id}` | This endpoint updates a specific knowledge base. |

Static analysis reports this compound-adjective issue. As per path instructions, this is an exact replacement for the contiguous Markdown line.

Committable suggestion

IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
| POST | `/v3/knowledgeBases` | This endpoint creates a new knowledge base. For more information about the usage of knowledge base related endpoints, see [Use knowledge bases](/tidb-cloud/use-chat2query-knowledge.md). |
| POST | `/v3/knowledgeBases` | This endpoint creates a new knowledge base. For more information about the usage of knowledge-base-related endpoints, see [Use knowledge bases](/tidb-cloud/use-chat2query-knowledge.md). |
Tools
LanguageTool

[grammar] ~110-~110: Use a hyphen to join words.
Context: ...mation about the usage of knowledge base related endpoints, see [Use knowledge ba...

(QB_NEW_EN_HYPHEN)

Sources: Path instructions, Linters/SAST tools

| POST | `/v2/dataSummaries` | This endpoint generates a data summary for your database schema, table schema, and column schema using artificial intelligence. |
| GET | `/v2/dataSummaries` | This endpoint retrieves all data summaries. |
| POST | `/v2/chat2data` | This endpoint enables you to generate and execute SQL statements using artificial intelligence by providing the data summary ID and instructions. |
| GET | `/v2/jobs/{job_id}` | This endpoint enables you to query the status of a specific data summary generation job. |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Functional Correctness · Quick win

Describe /v2/jobs/{job_id} as a general job-status endpoint.

The guide later uses this endpoint to poll /v3/chat2data jobs. The current description incorrectly limits it to data-summary generation jobs.

Suggested replacement
--- "a/tidb-cloud/use-chat2query-api.md"
+++ "b/tidb-cloud/use-chat2query-api.md"
@@ -127,7 +127,7 @@
 | POST   | `/v2/dataSummaries` | This endpoint generates a data summary for your database schema, table schema, and column schema using artificial intelligence. |
 | GET    | `/v2/dataSummaries` | This endpoint retrieves all data summaries. |
 | POST   | `/v2/chat2data` | This endpoint enables you to generate and execute SQL statements using artificial intelligence by providing the data summary ID and instructions. |
-| GET    | `/v2/jobs/{job_id}` | This endpoint enables you to query the status of a specific data summary generation job. |
+| GET    | `/v2/jobs/{job_id}` | This endpoint enables you to query the status of a specific job. |
 
 The steps to call `/v3/chat2data` and `/v2/chat2data` are the same. The following sections take `/v3/chat2data` as an example to show how to call it.
 

As per path instructions, this is an exact replacement for the contiguous Markdown line.

Committable suggestion

IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
| GET | `/v2/jobs/{job_id}` | This endpoint enables you to query the status of a specific data summary generation job. |
| GET | `/v2/jobs/{job_id}` | This endpoint enables you to query the status of a specific job. |

Source: Path instructions

To check the analysis status of your database, you can call the `/v2/jobs/{job_id}` endpoint as follows:

```bash
curl --digest --user ${PUBLIC_KEY}:${PRIVATE_KEY} --request GET 'https://<region>.data.dev.tidbcloud.com/api/v1beta/app/chat2query-<ID>`/endpoint/v2/jobs/{job_id}'\

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major · Functional Correctness · Quick win

Remove the stray backtick from the job-status URL.

The backtick becomes part of the single-quoted URL. The copied command therefore does not call the documented /v2/jobs/{job_id} endpoint.

Suggested replacement
--- "a/tidb-cloud/use-chat2query-api.md"
+++ "b/tidb-cloud/use-chat2query-api.md"
@@ -175,7 +175,7 @@
 To check the analysis status of your database, you can call the `/v2/jobs/{job_id}` endpoint as follows:
 
 ```bash
-curl --digest --user ${PUBLIC_KEY}:${PRIVATE_KEY} --request GET 'https://<region>.data.dev.tidbcloud.com/api/v1beta/app/chat2query-<ID>`/endpoint/v2/jobs/{job_id}'\
+curl --digest --user ${PUBLIC_KEY}:${PRIVATE_KEY} --request GET 'https://<region>.data.dev.tidbcloud.com/api/v1beta/app/chat2query-<ID>/endpoint/v2/jobs/{job_id}'\
  --header 'content-type: application/json'
 ```
 

As per path instructions, this is an exact replacement for the contiguous Markdown line.

Committable suggestion

IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
curl --digest --user ${PUBLIC_KEY}:${PRIVATE_KEY} --request GET 'https://<region>.data.dev.tidbcloud.com/api/v1beta/app/chat2query-<ID>`/endpoint/v2/jobs/{job_id}'\
curl --digest --user ${PUBLIC_KEY}:${PRIVATE_KEY} --request GET 'https://<region>.data.dev.tidbcloud.com/api/v1beta/app/chat2query-<ID>/endpoint/v2/jobs/{job_id}'\

Source: Path instructions

}
```

If `"status"` is `"done"`, the full data summary is ready and you can now generate and execute SQL statements for this database by calling `/v3/chat2data`. Otherwise, you need to wait and check the analysis status later until it is done.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Stability & Availability · Quick win

Stop polling after a failed job.

The current Otherwise branch treats failed jobs as pending jobs. Instruct readers to inspect reason when the job fails.

Suggested replacement
--- "a/tidb-cloud/use-chat2query-api.md"
+++ "b/tidb-cloud/use-chat2query-api.md"
@@ -194,7 +194,7 @@
 }
 ```
 
-If `"status"` is `"done"`, the full data summary is ready and you can now generate and execute SQL statements for this database by calling `/v3/chat2data`. Otherwise, you need to wait and check the analysis status later until it is done.
+If `"status"` is `"done"`, the full data summary is ready and you can now generate and execute SQL statements for this database by calling `/v3/chat2data`. If the job fails, stop polling and inspect `reason`. Otherwise, wait and check the analysis status later until it is done.
 
 In the response, `DataSummaryObject` represents AI exploration information of the given database. The structure of `DataSummaryObject` is as follows:
 

As per path instructions, this is an exact replacement for the contiguous Markdown line.

Committable suggestion

IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
If `"status"` is `"done"`, the full data summary is ready and you can now generate and execute SQL statements for this database by calling `/v3/chat2data`. Otherwise, you need to wait and check the analysis status later until it is done.
If `"status"` is `"done"`, the full data summary is ready and you can now generate and execute SQL statements for this database by calling `/v3/chat2data`. If the job fails, stop polling and inspect `reason`. Otherwise, wait and check the analysis status later until it is done.

Source: Path instructions

"relationships": {
"companies": {
"referencing_table": "...", // The table that references the `companies` table
"referencing_table_column": "..." // The column that references the `companies` table

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Functional Correctness · Quick win

Add the missing commas in DataSummaryObject.

The JavaScript example is invalid at Lines 216, 224, and 228. Add commas after "referencing_table_column": "...", "name": "companies", and "name": "city" so readers can parse the documented response shape.

As per path instructions, this fix spans noncontiguous lines, so this comment lists all required edits instead of using one replacement block.

Also applies to: 224-224, 228-228

Source: Path instructions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants