Skip to content

tiup: fix typos, flag names, Markdown, and wrong links in TiUP reference docs (#24486) - #24563

Open
ti-chi-bot wants to merge 5 commits into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-24486-to-release-8.5
Open

ti-chi-bot wants to merge 5 commits into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-24486-to-release-8.5

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #24486

What is changed, added, or deleted? (Required)

Fix typos, flag names, Markdown, and wrong links in the TiUP reference docs. These errors were found while reviewing the English docs for issues that affect the Japanese translation. Each fix is shown below; the same wrong text was also searched for in the rest of the docs.

File Before After
tiup-component-management.md The --all and --verbose list items have no space after -, so the list does not render Add the space
tiup-component-management.md "use the tiup install command to query the component list" (Install components section) "…to install components"
tiup-dm-topology-reference.md log_dir: "the data directory" "the log directory"
tiup-dm-topology-reference.md worker_servers: "the master node of the DM component" "the worker node"
tiup-command-mirror-publish.md tiup list -all tiup list --all
tiup-component-cluster-audit-cleanup.md "tiup clustercommand" "tiup cluster command"
tiup-component-cluster-check.md -enable-cpu, -enable-mem, -enable-disk, -cluster --enable-cpu, --enable-mem, --enable-disk, --cluster (as in the headings)
tiup-component-cluster-check.md The code fence lines in a blockquote have no space after > Add the space
tiup-component-cluster-clean.md "at lease one" "at least one"
tiup-component-cluster-display.md "all nodes are checked by default", "are checked" (copied from the check page) "displayed"
tiup-component-cluster-import.md . /ansible.cfg, -dir ./ansible.cfg, --dir
tiup-component-cluster-meta-backup.md (summary) "Use tiup dm list to check the cluster name" tiup cluster list
tiup-component-cluster-reload.md, tiup-component-cluster-upgrade.md -transfer-timeout --transfer-timeout
tiup-component-cluster-scale-out.md cluster list links to tiup-component-dm-list.md; the topology file links to tiup-dm-topology-reference.md tiup-component-cluster-list.md; tiup-cluster-topology-reference.md
tiup-component-dm-restart.md cluster list links to tiup-component-cluster-list.md tiup-component-dm-list.md (as in the other tiup dm pages)
tiup-component-dm-patch.md, tiup-component-dm-restart.md "[tiup dm display](…)" (the link is inside a code span and does not render) "tiup dm display"
tiup-component-dm-prune.md "scale in the cluster(/tiup/tiup-component-dm-scale-in.md)" "scale in the cluster"
tiup-component-dm-edit-config.md "topology file. of the specified cluster" "topology file of the specified cluster"
tiup-command-mirror-modify.md (summary) <component>[version] <component>[:version] (as in the syntax)
tiup-cluster-topology-reference.md ng_port: Continuous Profiling (the Manual Profiling page) Continuous Profiling

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

  • Related code change PR links (if applicable):
  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Corrected command examples, option names, version syntax, defaults, and cross-references across cluster, DM, and mirror guides.
    • Clarified cluster display behavior and which nodes are deployed by the DM topology configuration.
    • Updated the Continuous Profiling reference and corrected descriptions of log directories and component installation.
    • Fixed minor wording, punctuation, and formatting issues throughout the guides.

yahonda and others added 5 commits October 27, 2026 14:19
…nce docs

- Fix single-dash flags that should be double-dash: --all, --enable-cpu,
  --enable-mem, --enable-disk, --cluster, --dir, and --transfer-timeout.
- Fix list markers and code fences in blockquotes that did not render.
- Fix wrong descriptions: tiup install installs components, log_dir is
  the log directory, worker_servers deploys worker nodes, and display
  displays nodes.
- Fix wrong links and link formatting: cluster list, the cluster topology
  file, tiup dm display, and the scale-in link.
- Fix typos: "at lease", ". /ansible.cfg", a missing space, a stray
  period, tiup dm list in a cluster page summary, and <component>[:version].

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Use `<component>[:version]`, as the rest of the page does
(`tiup [flags] <component>[:version]`, `tiup uninstall [component][:version]`).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ti-chi-bot ti-chi-bot added area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Oct 27, 2026
@ti-chi-bot

ti-chi-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hfxsd for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Walkthrough

This pull request corrects TiUP documentation across cluster and DM commands, mirror and component-management commands, and topology references. The edits update command links, option syntax, examples, and descriptions.

Changes: TiUP documentation corrections

Layer / File(s) Summary
Cluster command documentation
tiup/tiup-component-cluster-*.md
Corrected option names, command references, examples, and descriptions across cluster command documentation.
DM command and topology documentation
tiup/tiup-component-dm-*.md, tiup/tiup-dm-topology-reference.md
Updated DM command references and corrected topology descriptions for log_dir and worker_servers.
General TiUP command and topology references
tiup/tiup-command-mirror-*.md, tiup/tiup-component-management.md, tiup/tiup-cluster-topology-reference.md
Corrected command syntax and descriptions, and updated the Continuous Profiling link.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

  • pingcap/docs#24486: This PR contains matching TiUP reference edits and is identified as the source change that this pull request cherry-picks.

Suggested reviewers: qiancai

Merge Risk: Low · up to e8bbe

The documentation is otherwise mergeable, but the install-section wording should be corrected for clarity.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly summarizes the documentation changes, including typo fixes, flag corrections, Markdown updates, and link corrections in TiUP reference docs.
Description check Passed The description covers the required change summary, affected versions, AI involvement, and applicable checklist items. The optional first-time contributor section is omitted, and no critical informati…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description covers the required change summary, affected versions, AI involvement, and applicable checklist items. The optional first-time contributor section is omitted, and no critical information is missing.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (22 skipped: 22 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


Review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 636d630 and e8bbe24.

Files selected for processing: 22
  • tiup/tiup-cluster-topology-reference.md
  • tiup/tiup-command-mirror-modify.md
  • tiup/tiup-command-mirror-publish.md
  • tiup/tiup-component-cluster-audit-cleanup.md
  • tiup/tiup-component-cluster-check.md
  • tiup/tiup-component-cluster-clean.md
  • tiup/tiup-component-cluster-display.md
  • tiup/tiup-component-cluster-import.md
  • tiup/tiup-component-cluster-meta-backup.md
  • tiup/tiup-component-cluster-reload.md
  • tiup/tiup-component-cluster-scale-out.md
  • tiup/tiup-component-cluster-upgrade.md
  • tiup/tiup-component-dm-edit-config.md
  • tiup/tiup-component-dm-patch.md
  • tiup/tiup-component-dm-prune.md
  • tiup/tiup-component-dm-restart.md
  • tiup/tiup-component-dm-scale-in.md
  • tiup/tiup-component-dm-scale-out.md
  • tiup/tiup-component-dm-start.md
  • tiup/tiup-component-dm-stop.md
  • tiup/tiup-component-management.md
  • tiup/tiup-dm-topology-reference.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

## Install components

You can use the `tiup install` command to query the component list. This usage of this command is as follows:
You can use the `tiup install` command to install components. This usage of this command is as follows:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Maintainability & Code Quality · Quick win

Use standard syntax wording for the install section.

The phrase “This usage of this command is as follows” is ungrammatical. Replace it with “The syntax of this command is as follows.”

Committable wording
--- "a/tiup/tiup-component-management.md"
+++ "b/tiup/tiup-component-management.md"
@@ -50,7 +50,7 @@
 
 ## Install components
 
-You can use the `tiup install` command to install components. This usage of this command is as follows:
+You can use the `tiup install` command to install components. The syntax of this command is as follows:
 
 - `tiup install <component>`: installs the latest stable version of a specified component.
 - `tiup install <component>[:version]`: installs the specified version of a specified component.
Committable suggestion

IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
You can use the `tiup install` command to install components. This usage of this command is as follows:
You can use the `tiup install` command to install components. The syntax of this command is as follows:

Source: Path instructions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants