[ti-chi-bot]

Auto generated by bot periodics.

Summary by CodeRabbit

• Bug Fixes
  • TiDB initialization now skips the DM-only rule file when loading and restoring rules. Other matching rule files continue to be processed with their existing label and component substitutions.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign csuzhangxc for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The release-7.1 initializer now skips dm_worker.rules.yml when it copies bundled rules and restores persisted TiDB rules. Other matching rules continue through the existing substitutions and restoration behavior.

Changes: TiDB rule filtering

Layer / File(s)	Summary
Rule copy and restore filtering monitor-snapshot/release-7.1/operator/init.sh	The initializer defines dm_worker.rules.yml as DM-only, copies bundled rule files individually while skipping it, and excludes it when restoring persisted TiDB rules. Other rule files continue through the existing substitutions.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

• pingcap/monitoring#1271: Applies the same DM-only rule filtering to the master snapshot and platform-monitoring initializers.
• pingcap/monitoring#1272: Applies the same DM-only rule filtering to the release-8.1 snapshot.

Suggested reviewers: asddongmen, fgksgf

Merge Risk: Minimal · up to 2f7d1

This change stops the TiDB monitor initializer from copying or restoring the DM-only rule file. Other rule files are handled as before. No merge-blocking risk was found.

Pre-merge checks: 4

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title names the scope (monitor-snapshot/release-7.1) and the chore type, and says files were updated from upstreams. The change set is a monitor-snapshot operator init.sh update that adds DM-only …
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the scope (monitor-snapshot/release-7.1) and the chore type, and says files were updated from upstreams. The change set is a monitor-snapshot operator init.sh update that adds DM-only rule handling and restores TiDB rules with an exclusion. The title is partially related: it identifies the release-7.1 monitor-snapshot area and the upstream sync, but it does not mention the actual behavior change (DM-only rule exclusion in init.sh). The title is specific enough to be recognized as a real part of the change and is not off-topic, so it is not a fail.

Finishing Touches

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit checks the rules at dawn
One DM file hops along
TiDB keeps the rest in view
Persisted rules get checked there too
The little hare declares it done}

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 2f550922-8139-4232-84a2-e1106b84658c

Commits

Reviewing files that changed from the base of the PR and between 615062c and 2f7d197.

Files ignored due to path filters: 1

• monitor-snapshot/release-7.1/ansible-monitor.tar.gz is excluded by !**/*.gz

Files selected for processing: 1

• monitor-snapshot/release-7.1/operator/init.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.