Conversation
Fixes known CVEs in both dependencies. grpc bump to v1.83.1 is intentionally not included here: it requires otel v1.44.0, which is incompatible with go.etcd.io/etcd/server/v3's use of the removed otelgrpc.UnaryServerInterceptor API across all 3.5.x releases. Verified: go build ./... compiles cleanly.
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request raises the required Go toolchain version to 1.26.0 and updates selected direct and indirect dependencies in ChangesGo toolchain and dependency updates
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The PR updates the Go toolchain and selected dependencies without an identified merge-blocking behavior change. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description covers the problem, dependency changes, compatibility impact, validation, documentation impact, and release note. However, the required issue reference is missing because it uses "Issue Number: None" instead of linking an issue with "close" or "ref".
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the module gate Comment |
|
Hi @vtatai. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@coderabbitai[bot]: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: coderabbitai[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Fixes known CVEs in both dependencies. grpc bump to v1.83.1 is intentionally not included here: it requires otel v1.44.0, which is incompatible with go.etcd.io/etcd/server/v3's use of the removed otelgrpc.UnaryServerInterceptor API across all 3.5.x releases.
Verified: go build ./... compiles cleanly.
What problem does this PR solve?
Issue Number: None
github.com/apache/thrift(v0.23.0) andgolang.org/x/crypto(v0.53.0) carry known CVEs that are fixed in later releases.What is changed and how it works?
Bumps:
github.com/apache/thriftv0.23.0 -> v0.24.0golang.org/x/cryptov0.53.0 -> v0.56.0google.golang.org/grpcis intentionally left unchanged in this PR. Bumping grpc to v1.83.1 (the version needed to fix its own known CVEs) pulls ingo.opentelemetry.io/otelv1.44.0 as a directgo.modrequirement. That breaks the build becausego.etcd.io/etcd/server/v3(every 3.5.x release) callsotelgrpc.UnaryServerInterceptor, an API removed in the otelgrpc version required by otel v1.44.0. Resolving that will need either an etcd 3.6.x migration or a patched etcd fork, and is tracked as separate follow-up work rather than bundled here.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No. Both are backward-compatible patch/minor version bumps within the same major version;
go build ./...compiles cleanly against the full module.Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note
Summary by CodeRabbit