Skip to content

stability-test-release-8.5-non-next-gen - 2026-09-19 16:03:37 - #6305

Closed
hongyunyan wants to merge 1 commit into
pingcap:release-8.5from
hongyunyan:stability-test-release-8.5-20260919_160333-degild
Closed

hongyunyan wants to merge 1 commit into
pingcap:release-8.5from
hongyunyan:stability-test-release-8.5-20260919_160333-degild

Conversation

@hongyunyan

@hongyunyan hongyunyan commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Automated stability test PR - adding empty line to Makefile

Summary by CodeRabbit

  • Style
    • Added a blank line to improve Makefile formatting.

@hongyunyan

Copy link
Copy Markdown
Contributor Author

/test pull-cdc-kafka-integration-heavy

@ti-chi-bot

ti-chi-bot Bot commented Sep 19, 2026

Copy link
Copy Markdown

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot

ti-chi-bot Bot commented Sep 19, 2026

Copy link
Copy Markdown

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be LGTMed and approved by the reviewers firstly.
  2. For pull requests to TiDB-x branches, it must have no failed tests.
  3. AFTER it has lgtm and approved labels, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 19, 2026
@hongyunyan

Copy link
Copy Markdown
Contributor Author

/test pull-cdc-kafka-integration-light

@hongyunyan

Copy link
Copy Markdown
Contributor Author

/test pull-cdc-mysql-integration-heavy

@hongyunyan

Copy link
Copy Markdown
Contributor Author

/test pull-cdc-mysql-integration-light

@ti-chi-bot ti-chi-bot Bot added the contribution This PR is from a community contributor. label Sep 19, 2026
@hongyunyan

Copy link
Copy Markdown
Contributor Author

/test pull-cdc-storage-integration-heavy

@ti-chi-bot

ti-chi-bot Bot commented Sep 19, 2026

Copy link
Copy Markdown

Hi @hongyunyan. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Sep 19, 2026
@hongyunyan

Copy link
Copy Markdown
Contributor Author

/test pull-cdc-storage-integration-light

@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 19, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 19, 2026

Copy link
Copy Markdown

@hongyunyan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test pull-cdc-kafka-integration-heavy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot

ti-chi-bot Bot commented Sep 19, 2026

Copy link
Copy Markdown

@hongyunyan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test pull-cdc-kafka-integration-light

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot

ti-chi-bot Bot commented Sep 19, 2026

Copy link
Copy Markdown

@hongyunyan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test pull-cdc-mysql-integration-heavy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot

ti-chi-bot Bot commented Sep 19, 2026

Copy link
Copy Markdown

@hongyunyan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test pull-cdc-mysql-integration-light

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot

ti-chi-bot Bot commented Sep 19, 2026

Copy link
Copy Markdown

@hongyunyan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test pull-cdc-storage-integration-heavy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot

ti-chi-bot Bot commented Sep 19, 2026

Copy link
Copy Markdown

@hongyunyan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test pull-cdc-storage-integration-light

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 91aa40a8-aae4-4908-9ee7-4e0b34df8245

📥 Commits

Reviewing files that changed from the base of the PR and between 07713a9 and 4f6b4b9.

📒 Files selected for processing (1)
  • Makefile

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Makefile adds one blank line after the check-next-gen-grafana target. The target logic remains unchanged.

Changes

Makefile formatting

Layer / File(s) Summary
Grafana target formatting
Makefile
Adds a blank line after the check-next-gen-grafana recipe. No target behavior changes.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states that the PR adds an empty line to the Makefile, but it omits the required template sections, including the issue number, change details, test checklist, compatibility answers, d… Complete the repository template. Add an Issue Number line, describe the change and its purpose, select the applicable test item or document test steps, answer both Questions, and provide a release note or None.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title identifies the automated stability test and the target release variant. It is related to the pull request objective, although it does not mention the Makefile change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description states that the PR adds an empty line to the Makefile, but it omits the required template sections, including the issue number, change details, test checklist, compatibility answers, documentation impact, and release note.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit spots a tidy line
The Grafana checks still run fine
One blank space rests below
No code changes show
The Makefile hops in time

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Sep 19, 2026

Copy link
Copy Markdown

@coderabbitai[bot]: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot

ti-chi-bot Bot commented Sep 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: coderabbitai[bot]
Once this PR has been reviewed and has the lgtm label, please assign hongyunyan for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hongyunyan hongyunyan closed this Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant