Skip to content

refactor(mobile): look up viewed pull request files with a Set #18848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saphid wants to merge 5 commits into
base: main
Choose a base branch
from
+7 −3
Open

refactor(mobile): look up viewed pull request files with a Set #18848

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
db7cca7
perf(mobile): index viewed files before rendering pull requests
saphid Oct 12, 2026
426cf95
Merge remote-tracking branch 'origin/main' into pr18848-fix
saphid Oct 14, 2026
519abd2
test(mobile): drop the read-counting viewed files test
saphid Oct 14, 2026
05dc6d1
fix: integrate current main while preserving PR 18848 behavior
saphid Oct 23, 2026
551d5aa
Merge commit 'b823dcf5c6dab2fe489bc7ac4d448436acc6fa39' into ready/mo…
saphid Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions apps/mobile/src/features/pull-requests/usePullRequestFilesViewed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { RegistryContext, useAtomRefresh, useAtomValue } from "@effect/atom-reac
import { squashAtomCommandFailure } from "@t3tools/client-runtime/state/runtime";
import type { PullRequestDetail } from "@t3tools/contracts";
import { AsyncResult } from "effect/reactivity";
import { use, useState } from "react";
import { use, useMemo, useState } from "react";
import { composerPullRequests } from "../../state/pull-requests";
import { useEnvironmentQuery } from "../../state/query";
import { useAtomCommand } from "../../state/use-atom-command";
Expand Down Expand Up @@ -32,8 +32,12 @@ export function usePullRequestFilesViewed(params: PullRequestParams, pr: PullReq
setState((current) =>
change(current.key === scopeKey ? current : { key: scopeKey, presses: {}, error: null }),
);
const serverViewed = (path: string) =>
query.data?.files.some((file) => file.path === path && file.state === "viewed") ?? false;
const viewedPaths = useMemo(
() =>
new Set(query.data?.files.filter((file) => file.state === "viewed").map((file) => file.path)),
[query.data],
);
const serverViewed = (path: string) => viewedPaths.has(path);
const isViewed = (path: string) => overlay[path] ?? serverViewed(path);
const toggle = async (path: string) => {
if (!supported || !allowed || !query.data) return;
Expand Down
Loading