Skip to content

fix(web): show the thread details tooltip - #24864

Merged
Yash-Singh1 merged 2 commits into
pingdotgg:mainfrom
UtkarshUsername:fix/thread-details-tooltip
Oct 28, 2026
Merged

Yash-Singh1 merged 2 commits into
pingdotgg:mainfrom
UtkarshUsername:fix/thread-details-tooltip

Conversation

@UtkarshUsername

@UtkarshUsername UtkarshUsername commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Problem

The thread details button does not show a tooltip like the adjacent terminal drawer and right panel buttons.

Change

Use the same wrapping tooltip trigger as the adjacent buttons rather than composing the tooltip directly onto the popover trigger. Preserve the original "Toggle thread details" label and retain the keyboard shortcut hint. Keep the popover trigger for floating presentation and use the toggle callback for docked presentation. This shared web control also serves desktop.

Scope and approval

Small, focused fix to the existing tooltip on one control. No new capability or setting.

Verification

Before:
image

After:
image

  • vp run check:changed a6aca345d5c107aee5bf4e552a517c8474a67797: format, lint, both knip checks, and affected-package typechecks passed.
  • Source comparison with the adjacent terminal drawer and right panel controls.
  • Browser verification was intentionally not performed at the request of the developer, who will verify the UI and add before/after screenshots.

Implemented with GPT-6.1-sol through the Codex harness.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Oct 25, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Oct 25, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at a2be155

Macroscope's review found this PR approvable — Restores the thread-details tooltip using the same wrapper pattern as neighboring controls, while retaining docked and popover interactions. The change is limited to UI presentation and event wiring, with no product-default or data changes.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

The saved review base belongs to an older reviewed commit. This saved history cannot establish the base for an incremental review. Comment @coderabbitai full review to establish a new review baseline. No full review was started, and the last reviewed checkpoint was preserved.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between cb0b206 and 82b28c7.

Files selected for processing: 1
  • apps/web/src/components/chat/PanelLayoutControls.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

Walkthrough

The thread panel control now handles toggle presses through Toggle’s onPressedChange for non-popover presentations. For popover presentation, it uses PopoverTrigger and leaves that handler unset. The tooltip label is now “Thread details.”

Changes: Thread panel control

Layer / File(s) Summary
Thread toggle behavior and rendering
apps/web/src/components/chat/PanelLayoutControls.tsx
Non-popover presentations call onToggleThreadPanel when the pressed state changes. Popover presentation uses PopoverTrigger and leaves onPressedChange unset. The tooltip trigger renders a wrapper span, and its label is “Thread details.”

Priority: Pending latest changes

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · previous review 82b28

No actionable merge-blocking risk remains from the reviewed change.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: fixing the missing thread details tooltip.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description follows the template's Problem, Change, Scope and approval, and Verification sections. It explains the tooltip bug, the wrapping tooltip trigger fix, the popover versus toggle split, a…
Full details: Description check

Explanation

The description follows the template's Problem, Change, Scope and approval, and Verification sections. It explains the tooltip bug, the wrapping tooltip trigger fix, the popover versus toggle split, and the small scope. It also gives a check command and before/after images, and it discloses that browser verification was not run. Two gaps remain. First, the Scope section does not link a triaged issue or maintainer approval, and it does not explain why the fix qualifies as a very small, obvious bug fix without one. Second, the Verification section cites a commit-based check command but gives no observed result for the tooltip behavior itself. The author states that the developer will verify the UI, so the verification gap is not critical. The description is mostly complete, so it passes. The approval gap is still worth fixing because the template requires it for every change.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@macroscopeapp
macroscopeapp Bot dismissed their stale review October 25, 2026 12:15

Dismissing prior approval to re-evaluate cb0b206

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Oct 25, 2026
@UtkarshUsername
UtkarshUsername force-pushed the fix/thread-details-tooltip branch from cb0b206 to 82b28c7 Compare October 28, 2026 07:36
@macroscopeapp
macroscopeapp Bot dismissed their stale review October 28, 2026 07:43

Dismissing prior approval to re-evaluate a2be155

@Yash-Singh1
Yash-Singh1 merged commit cb4fe60 into pingdotgg:main Oct 28, 2026
32 checks passed
@UtkarshUsername
UtkarshUsername deleted the fix/thread-details-tooltip branch October 28, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants