Repository navigation
fix(web): show the thread details tooltip - #24864
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Restores the thread-details tooltip using the same wrapper pattern as neighboring controls, while retaining docked and popover interactions. The change is limited to UI presentation and event wiring, with no product-default or data changes. You can add or adjust custom eligibility rules. Learn more. |
|
Important Review skippedThe saved review base belongs to an older reviewed commit. This saved history cannot establish the base for an incremental review. Comment You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Thread toggle behavior and rendering apps/web/src/components/chat/PanelLayoutControls.tsx |
Non-popover presentations call onToggleThreadPanel when the pressed state changes. Popover presentation uses PopoverTrigger and leaves onPressedChange unset. The tooltip trigger renders a wrapper span, and its label is “Thread details.” |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Suggested reviewers: juliusmarminge
Merge Risk: 
Minimal · previous review 82b28
-
No actionable merge-blocking risk remains from the reviewed change.
Pre-merge checks: 
4
-
Full details: Description check
-
Explanation
The description follows the template's Problem, Change, Scope and approval, and Verification sections. It explains the tooltip bug, the wrapping tooltip trigger fix, the popover versus toggle split, and the small scope. It also gives a check command and before/after images, and it discloses that browser verification was not run. Two gaps remain. First, the Scope section does not link a triaged issue or maintainer approval, and it does not explain why the fix qualifies as a very small, obvious bug fix without one. Second, the Verification section cites a commit-based check command but gives no observed result for the tooltip behavior itself. The author states that the developer will verify the UI, so the verification gap is not critical. The description is mostly complete, so it passes. The approval gap is still worth fixing because the template requires it for every change.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Dismissing prior approval to re-evaluate cb0b206
cb0b206 to
82b28c7
Compare
Dismissing prior approval to re-evaluate a2be155
Problem
The thread details button does not show a tooltip like the adjacent terminal drawer and right panel buttons.
Change
Use the same wrapping tooltip trigger as the adjacent buttons rather than composing the tooltip directly onto the popover trigger. Preserve the original "Toggle thread details" label and retain the keyboard shortcut hint. Keep the popover trigger for floating presentation and use the toggle callback for docked presentation. This shared web control also serves desktop.
Scope and approval
Small, focused fix to the existing tooltip on one control. No new capability or setting.
Verification
Before:

After:

vp run check:changed a6aca345d5c107aee5bf4e552a517c8474a67797: format, lint, both knip checks, and affected-package typechecks passed.Implemented with GPT-6.1-sol through the Codex harness.