Skip to content

fix(mobile): keep expanding composer text above its toolbar #25396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yash-Singh1 merged 1 commit into from
Oct 26, 2026
Merged

fix(mobile): keep expanding composer text above its toolbar #25396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 4 additions & 34 deletions apps/mobile/src/features/threads/ThreadComposer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,48 +161,18 @@ export function useCompactComposerEditor(text: ScaledTextRole, value: string) {
(contentHeight > text.lineHeight * 1.5 ||
(compactWidth > 0 && contentSize.width > compactWidth));
const compactRowHeight = Math.max(44, minimum);
const animatedHeight = useSharedValue(height);
const surfaceHeight = useSharedValue(compactRowHeight);
const targetSurfaceHeight = isExpanded ? height + 52 : compactRowHeight;
const expansion = useSharedValue(0);
useLayoutEffect(() => {
const config = { duration: 180, reduceMotion: ReduceMotion.System };
if (Platform.OS === "android") {
animatedHeight.set(height);
surfaceHeight.set(targetSurfaceHeight);
expansion.set(Number(isExpanded));
return;
}
// Resolve wrapping at the destination width before animating vertically.
// Intermediate widths otherwise produce taller measurements mid-transition.
let nextFrame: number | undefined;
const frame = requestAnimationFrame(() => {
nextFrame = requestAnimationFrame(() => {
animatedHeight.set(withTiming(height, config));
surfaceHeight.set(withTiming(targetSurfaceHeight, config));
expansion.set(withTiming(Number(isExpanded), config));
});
});
return () => {
cancelAnimationFrame(frame);
if (nextFrame !== undefined) cancelAnimationFrame(nextFrame);
};
}, [animatedHeight, expansion, height, isExpanded, surfaceHeight, targetSurfaceHeight]);
const containerStyle = useAnimatedStyle(() => ({
height: surfaceHeight.value,
}));
const editorStyle = useAnimatedStyle(() => ({
position: "absolute",
overflow: "hidden",
height: animatedHeight.value,
height,
left: isExpanded ? 14 : editorX.value + 4,
right: isExpanded ? 14 : rowWidth.value - editorX.value - editorWidth.value + 4,
bottom:
(compactRowHeight - minimum) / 2 + expansion.value * (52 - (compactRowHeight - minimum) / 2),
// The full-width editor must move above the controls in the same frame it widens.
bottom: isExpanded ? 52 : (compactRowHeight - minimum) / 2,
}));
return {
isExpanded,
containerStyle,
containerStyle: { height: isExpanded ? height + 52 : compactRowHeight },
editorStyle,
onRowLayout: (event: { nativeEvent: { layout: { width: number } } }) => {
rowWidth.set(event.nativeEvent.layout.width);
Expand Down
Loading