Skip to content

fix(server): clear unreachable preview downloads after a server restart #25436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 1 commit into from
Oct 30, 2026
Merged

fix(server): clear unreachable preview downloads after a server restart #25436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions apps/server/src/preview/ServerBrowser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1057,6 +1057,27 @@ it.live.each(["save failed", "oversized"])(
).pipe(Effect.provide(layer)),
);

it.live("a restarted server removes the previous run's downloads and keeps its profiles", () =>
Effect.scoped(
Effect.gen(function* () {
const { stateDir } = yield* ServerConfig.ServerConfig;
const fs = yield* FileSystem.FileSystem;
const path = yield* Path.Path;
const previousTab = path.join(stateDir, "server-browser", "downloads", "previous-tab");
const profile = path.join(stateDir, "server-browser", "profiles", "default");
yield* fs.makeDirectory(previousTab, { recursive: true });
yield* fs.makeDirectory(profile, { recursive: true });
yield* fs.writeFileString(path.join(previousTab, "report.csv"), "a,b");
yield* fs.writeFileString(path.join(profile, "Preferences"), "{}");

yield* Layer.build(ServerBrowser.layer);

expect(yield* fs.exists(previousTab)).toBe(false);
expect(yield* fs.readFileString(path.join(profile, "Preferences"))).toBe("{}");
}),
).pipe(Effect.provide(dependencies)),
);

it.live("a page's file picker goes to the controller and takes its uploaded files", () =>
Effect.scoped(
Effect.gen(function* () {
Expand Down
6 changes: 6 additions & 0 deletions apps/server/src/preview/ServerBrowser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,6 +903,12 @@ const make = Effect.gen(function* () {
};

const downloadsRoot = NodePath.join(config.stateDir, "server-browser", "downloads");
// Saved downloads are indexed in memory, so an earlier run's files can never be opened again.
yield* Effect.tryPromise(() => NodeFSP.rm(downloadsRoot, { recursive: true, force: true })).pipe(
Effect.catch((cause) =>
Effect.logWarning("server preview could not clear earlier downloads", { cause }),
),
);
// Tab ids are opaque server strings; hashing keeps them out of the path.
const downloadDir = (tab: ServerTab) =>
NodePath.join(
Expand Down
Loading