Repository navigation
docs(mcp): t3_thread_update lists only its rename and title actions - #26130
juliusmarminge wants to merge 1 commit into
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Clarifies the thread-update actions and directs pull-request linking to its separate tools. This documentation-only change leaves runtime behavior and product defaults unchanged. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Document thread update actions docs/orchestration-v2/orchestrator-mcp-server.md |
The documentation limits t3_thread_update actions to rename and regenerate_title. It assigns pull-request linking and unlinking to separate tools and removes the prior input and project-ID details. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other · Severity of issue fixed: Low
Possibly related PRs
- pingdotgg/t3code#25423: Removes pull-request actions from
t3_thread_update; this change documents that action contract. - pingdotgg/t3code#25124: Consolidates MCP tools and removes pull-request actions from
t3_thread_update. - pingdotgg/t3code#24850: Revises MCP tool descriptions, including the separation between thread metadata actions and pull-request tools.
Suggested reviewers: t3dotgg
Merge Risk: 
Minimal · up to da4e0
-
The documentation correction is limited in scope and accurately reflects the supported MCP tools.
Pre-merge checks: 
4
-
Full details: Title check
-
Explanation
The title "docs(mcp): t3_thread_update lists only its rename and title actions" follows conventional commit style and names the main change: the docs for t3_thread_update now list only rename and regenerate_title. The diff matches this: it removes the link and unlink actions from the docs and points readers to the separate PR tools. The wording "title actions" is slightly imprecise, since the actions are rename and regenerate_title, but the title still describes the real change.
Full details: Description check
-
Explanation
The description follows the repository template. It has a Problem section that explains the stale docs and gives a reproduction on main with the advertised schema and decode error. It has a Change section that says what was edited and what was left alone. It has a Scope and approval section that links issue
#26118. It has a Verification section that gives a runtime transcript, the files checked, and the check results, and it says that no capture or new test was added, which fits a docs-only change. The template does not require a separate approval comment beyond the linked issue, and the linked issue states the maintainer-facing scope, so the author has covered the required information. The Scope section is brief, but the linked issue supplies the approval context.
Full details: Linked Issues check
-
Explanation
Issue
#26118requires the t3_thread_update section to stop listing link_pull_request and unlink_pull_request as actions. It also requires accurate guidance for rename and regenerate_title, and pointers to the separate PR-link tools. The diff changes only the t3_thread_update paragraph in docs/orchestration-v2/orchestrator-mcp-server.md (+4/-4). The new text lists rename (requires title) and regenerate_title (rejects one), and names link_pull_request and unlink_pull_request as separate tools. At head, packages/contracts/src/threadMetadataMcp.ts defines ThreadMetadataMcpAction as Schema.Literals(["rename", "regenerate_title"]). Its filter states 'rename requires title; regenerate_title does not accept one.', which matches the new text. apps/server/src/mcp/toolkits/pullRequests/tools.ts defines Tool.make("link_pull_request") and Tool.make("unlink_pull_request") as separate tools, which matches the new pointer. The removed link-input and project-ID sentence described the obsolete action. The unchanged sentence on branch and workspace changes was not re-verified against source. The issue's restoration check is met for this section. I did not search the rest of the page for other PR-link action mentions. The issue scopes its request to this section, so this does not affect the verdict.
Full details: Out of Scope Changes check
-
Explanation
The only file changed is docs/orchestration-v2/orchestrator-mcp-server.md, and the only hunk is inside the t3_thread_update description. The hunk removes the obsolete list of link and unlink actions, the link-input description, and the recorded-project-ID sentence. It adds the accurate rename and regenerate_title constraints and a pointer to the separate PR-link tools. The PR makes no runtime, contract, or test changes. The PR description states that the tool count and other sections are left unchanged, and the diff confirms this. No changed hunk falls outside issue
#26118's scope.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Problem
The
t3_thread_updatesection ofdocs/orchestration-v2/orchestrator-mcp-server.mdlistslink_pull_requestandunlink_pull_requestas actions. https://git.cafe/pingdotgg/t3code/pulls/25423 (ed44f25) removed both from the tool, which now accepts onlyrenameandregenerate_title, so input written from the docs gets rejected. Reproduced on main 570d4b0: the server advertisesactionas{"enum":["rename","regenerate_title"]}, and decoding{action:"link_pull_request"}or{action:"unlink_pull_request"}withThreadMetadataMcpUpdateInputfails withExpected "rename" | "regenerate_title". v0.1.3 and the 2026-10-27 nightly show the same mismatch.Change
The paragraph now lists the two real actions:
renamerequirestitle, andregenerate_titlerejects it. It also points readers to the separatelink_pull_requestandunlink_pull_requesttools for pull request links. The sentence about link input and the recorded project ID described the removed action, so it is gone. The rest of the section still matches the code and is unchanged. The tool count and the other sections are tracked separately and are left alone.Scope and approval
Fixes #26118
Verification
t3_thread_update(advertisedJsonSchema) and decodes the documented actions withThreadMetadataMcpUpdateInput.renameis accepted;link_pull_requestandunlink_pull_requestare rejected. The separate PR toolkit registerslink_pull_requestandunlink_pull_request.apps/server)packages/contracts/src/threadMetadataMcp.ts,apps/server/src/mcp/toolkits/orchestrator/tools.ts,apps/server/src/mcp/ThreadMetadataMcpService.ts, andapps/server/src/mcp/toolkits/pullRequests/tools.ts.vp run check:changed: format passes; knip and the patch check are skipped because only docs changed.Model and harness: Claude Opus 5.5 (lead, implementation, review B) and GPT-6.1 Sol (review A), run through T3 Code.
🤖 Generated with Claude Code