Skip to content

fix(mobile): the portrait Duo drawer's last rows clear its tab bar - #26140

Open
jakeleventhal wants to merge 1 commit into
pingdotgg:mainfrom
jakeleventhal:fix/duo-portrait-drawer-tab-clearance
Open

jakeleventhal wants to merge 1 commit into
pingdotgg:mainfrom
jakeleventhal:fix/duo-portrait-drawer-tab-clearance

Conversation

@jakeleventhal

Copy link
Copy Markdown
Contributor

On an unfolded iPhone Duo in portrait, the sidebar drawer draws its own floating tab bar, but lists in the drawer only reserved the Duo's usual 16pt of bottom clearance. Even scrolled to the bottom, the last Settings row (Archive) stayed behind the tab bar. The Chats and PRs lists use the same clearance. Landscape was fine because the tabs move to the system side rail.

The Duo branch of bottomClearance in WorkspaceRootScreen assumed the column's safe area already covered everything at the bottom. That holds for the search toolbar and keyboard, but not for WorkspaceSidebarTabs, which renders in the portrait drawer exactly when sidebarPicker is true. That case now reserves 80pt, the same value the other iOS sidebar-picker path already uses. Other Duo layouts are unchanged.

Before / after (unfolded iPhone Duo simulator, portrait, Settings drawer scrolled to the bottom):

Before After

Done with Claude Opus 5.5 in Claude Code (running in T3 Code).

🤖 Generated with Claude Code

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 27, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at af57adb

Macroscope's review found this PR approvable — Adds bottom spacing to the iOS Duo sidebar-picker layout so the last drawer rows can clear its tab bar. The change is limited to presentation, with no product-default or persistent-data changes.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between af57adb and 1cb14bc.

Files selected for processing: 1
  • apps/mobile/src/features/workspace/WorkspaceRootScreen.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Walkthrough

On iOS Duo devices, the workspace bottom-clearance calculation now adds 80 points when sidebarPicker is active and 16 points otherwise.

Changes: Duo workspace clearance

Layer / File(s) Summary
Sidebar picker clearance
apps/mobile/src/features/workspace/WorkspaceRootScreen.tsx
When sidebarPicker is active on iOS Duo devices, the calculation adds 80 points. Otherwise, it adds 16 points.

Priority: Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Possibly related PRs

Suggested labels: 📱 Native Change

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · up to 1cb14

The targeted Duo portrait drawer clearance change has no identified merge-blocking risk.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title is concise, specific, and accurately describes the mobile Duo drawer clearance fix.
Description check Passed The description clearly explains the problem, affected layouts, code change, scope, and expected result. It includes before-and-after UI evidence and identifies the agent used. It does not provide an …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description clearly explains the problem, affected layouts, code change, scope, and expected result. It includes before-and-after UI evidence and identifies the agent used. It does not provide an explicit issue or approval link, or a separate manual verification result, but the description is otherwise mostly complete.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jakeleventhal
jakeleventhal force-pushed the fix/duo-portrait-drawer-tab-clearance branch from af57adb to 1cb14bc Compare October 28, 2026 13:02
@juliusmarminge juliusmarminge added bugfix Fix PR opened by an issue lead; enters the PR loop pr:gate-failed A land gate failed labels Oct 29, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fix PR opened by an issue lead; enters the PR loop pr:gate-failed A land gate failed size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants