Repository navigation
fix(mobile): the portrait Duo drawer's last rows clear its tab bar - #26140
jakeleventhal wants to merge 1 commit into
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Adds bottom spacing to the iOS Duo sidebar-picker layout so the last drawer rows can clear its tab bar. The change is limited to presentation, with no product-default or persistent-data changes. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Sidebar picker clearance apps/mobile/src/features/workspace/WorkspaceRootScreen.tsx |
When sidebarPicker is active on iOS Duo devices, the calculation adds 80 points. Otherwise, it adds 16 points. |
Priority:
Estimated code review effort: 2 (Simple) | ~5 minutes
Change: Bug fix
Possibly related PRs
- pingdotgg/t3code#24206: Changes Duo workspace search, sidebar tabs, and related clearance in
WorkspaceRootScreen. - pingdotgg/t3code#24666: Changes iOS workspace tab placement and sidebar tab handling in
WorkspaceRootScreen. - pingdotgg/t3code#25765: Changes the Duo bottom-clearance calculation in
WorkspaceRootScreen.
Suggested labels: 📱 Native Change
Suggested reviewers: juliusmarminge
Merge Risk: 
Minimal · up to 1cb14
-
The targeted Duo portrait drawer clearance change has no identified merge-blocking risk.
Pre-merge checks: 
4
-
Full details: Description check
-
Explanation
The description clearly explains the problem, affected layouts, code change, scope, and expected result. It includes before-and-after UI evidence and identifies the agent used. It does not provide an explicit issue or approval link, or a separate manual verification result, but the description is otherwise mostly complete.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
af57adb to
1cb14bc
Compare
On an unfolded iPhone Duo in portrait, the sidebar drawer draws its own floating tab bar, but lists in the drawer only reserved the Duo's usual 16pt of bottom clearance. Even scrolled to the bottom, the last Settings row (Archive) stayed behind the tab bar. The Chats and PRs lists use the same clearance. Landscape was fine because the tabs move to the system side rail.
The Duo branch of
bottomClearanceinWorkspaceRootScreenassumed the column's safe area already covered everything at the bottom. That holds for the search toolbar and keyboard, but not forWorkspaceSidebarTabs, which renders in the portrait drawer exactly whensidebarPickeris true. That case now reserves 80pt, the same value the other iOS sidebar-picker path already uses. Other Duo layouts are unchanged.Before / after (unfolded iPhone Duo simulator, portrait, Settings drawer scrolled to the bottom):
Done with Claude Opus 5.5 in Claude Code (running in T3 Code).
🤖 Generated with Claude Code