Avoid recursive config watches under proot#3803
Draft
jamesx0416 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
FileSystem.watchbehavior outside proot.node:fs.watchand emit update events for changed config filenames.Why
Effect recursive directory watching expands into hundreds of
fs_eventhandles under proot for the T3 userdata config directory. On Android/proot this adds avoidable event-loop and native watcher pressure for two config files that only need shallow directory watching.This keeps live reload behavior for
keybindings.jsonandsettings.jsonwhile avoiding recursive watcher fanout whenPROOT_L2S_DIRis present.Checklist
Validation:
pnpm --filter t3 typecheckNote
Avoid recursive config watches in proot environments
watchConfigDirectoryhelper in keybindings.ts and serverSettings.ts that selects a watch implementation based on thePROOT_L2S_DIRenvironment variable.PROOT_L2S_DIRis set, uses Node'sfs.watchdirectly (wrapped inStream.callback) instead of the EffectFileSystem.watch, avoiding recursive watch issues under proot.PROOT_L2S_DIRis not set, delegates to the existingfs.watchEffect implementation with no behavior change.Macroscope summarized fc93ae1.