feat(source-control): detect outdated GitHub CLI instead of "Not authenticated"

[Noisemaker111]

feat(source-control): detect outdated GitHub CLI instead of "Not authenticated"

Draft — opening for early feedback. Fixes #3806.

Problem

When the server's gh predates gh auth status --json (gh v2.81.0, cli/cli#11544), the auth probe fails with unknown flag: --json and the Source Control row shows a misleading "Not authenticated" even though the user is signed in. gh auth login never clears it.

What this does

Adds an outdated source-control auth status and surfaces it clearly instead of faking a sign-out.

Contracts — packages/contracts/src/sourceControl.ts

• New outdated literal on SourceControlProviderAuthStatus.

Server

• SourceControlProviderDiscovery.ts: thread the CLI --version output and host platform (via the existing ambient HostProcessPlatform reference) into parseAuth as optional fields — no change to probeSourceControlProvider's public signature, and existing parseAuth callers/tests keep compiling.
• GitHubSourceControlProvider.ts: classify the unknown flag: --json / sub-2.81.0 case as outdated, and put an OS-appropriate upgrade command in auth.detail (brew upgrade gh / winget upgrade --id GitHub.cli / sudo apt … gh). Version compare reuses @t3tools/shared/semver.

Web — apps/web/src/components/settings/SourceControlSettings.tsx

• Version number rendered red, an "Outdated CLI" badge, and a copyable upgrade command line, for auth.status === "outdated".

Screenshot

Testing

• Added unit tests in GitHubSourceControlProvider.test.ts for both detection paths: the --json flag rejection, and the version-gate fallback (with per-platform command assertions).
• Draft caveat: I couldn't run the repo toolchain in my environment — please let CI run pnpm typecheck + tests. I followed existing patterns (ambient HostProcessPlatform usage, Effect .gen in the probe pipe) but haven't compiled locally.

Deliberately out of scope (separate follow-up PR, if you want it)

• Package-manager-aware upgrade command — detect brew vs. apt/dnf/pacman vs. winget/scoop/choco/MSI, rather than one default per OS. This is the part that needs a product/design call (how much probing is worth the DX), so I kept it out of this minimal fix.
• One-click "run upgrade in a terminal at repo root" — the terminal RPC is ScopedThreadRef/project-scoped, and the Settings page only has an environmentId, so wiring a run button there is a larger cross-cutting change.

Note

Detect outdated GitHub CLI and surface platform-specific upgrade command in source control settings

• Adds an 'outdated' auth status to the source control contract, returned when gh is too old (below v2.81.0) or rejects the --json flag, instead of treating the state as unauthenticated.
• Adds isOutdatedGitHubCli, parseGitHubCliVersion, and gitHubCliUpgradeCommand helpers in GitHubSourceControlProvider.ts to detect the outdated condition and map the host platform to a specific upgrade command (brew, winget, or apt).
• Passes CLI version and host platform through SourceControlProviderDiscovery.ts to parseAuth so providers can produce the new status.
• Renders a warning badge, highlighted version number, and a copyable upgrade command in SourceControlSettings.tsx when auth status is 'outdated'.

📊 Macroscope summarized c529532. 4 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted

🗂️ Filtered Issues

No issues evaluated.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4729112d-6408-4354-ba1d-7ce6b580b77a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

🟠 High sourceControl/GitHubSourceControlProvider.ts:105

parseGitHubAuth now returns status: "outdated" when the installed gh is too old, but the readiness checks in CommandPalette.tsx and GitActionsControl.tsx only gate on "unauthenticated" and treat every other status as ready. So a user with an outdated, signed-out gh sees GitHub marked usable, and pull-request actions are incorrectly enabled — they fail at runtime instead of being blocked up front. Either add "outdated" to the set of statuses that block readiness, or document why it should be treated as ready.

🤖 Copy this AI Prompt to have your agent fix this:

In file @apps/server/src/sourceControl/GitHubSourceControlProvider.ts around line 105:

`parseGitHubAuth` now returns `status: "outdated"` when the installed `gh` is too old, but the readiness checks in `CommandPalette.tsx` and `GitActionsControl.tsx` only gate on `"unauthenticated"` and treat every other status as ready. So a user with an outdated, signed-out `gh` sees GitHub marked usable, and pull-request actions are incorrectly enabled — they fail at runtime instead of being blocked up front. Either add `"outdated"` to the set of statuses that block readiness, or document why it should be treated as ready.