Optimize provider update pill renders

[cursor]

What Changed

• Removed the provider update pill's effect-driven timestamp mirroring and replaced it with a mount-time baseline.
• Seeded the rendered pill view from the first computed view so initial/remount renders do not need an extra post-commit state update.
• Moved transition-only bookkeeping (pendingView, dismiss-after-exit key) into refs so it does not schedule additional renders.
• Kept remaining synchronization/timer effects inside named hooks rather than directly in the component body.

Why

react-doctor flagged SidebarProviderUpdatePill for redundant effect-driven state and state used only in handlers. The old mount path did extra commits to mirror provider timestamps and seed rendered state. After the fix, the targeted SidebarProviderUpdatePill findings are gone: react-doctor issue count dropped from 162 to 158 overall, and State only used in handlers dropped from 6 to 4 with no remaining hit in this component.

React Scan proof:

• Before recording: react_scan_provider_pill_before.mp4 — 5 identical remounts ended at 10 Profiler commits.
• After recording: react_scan_provider_pill_after.mp4 — the same 5 remounts ended at 5 Profiler commits.

UI Changes

No intended visual UI change. The recordings demonstrate the render behavior change with React Scan enabled.

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

Validation:

• corepack pnpm --filter @t3tools/web exec tsgo --noEmit
• corepack pnpm dlx react-doctor@latest . --verbose --category performance --no-telemetry (expected non-zero due to remaining unrelated findings)
• NODE_OPTIONS="--experimental-strip-types" corepack pnpm exec vp check
• corepack pnpm exec vp run typecheck

  

Note

Optimize SidebarProviderUpdatePill renders by replacing state with refs and a mount-time timestamp

• Replaces visibleAfterIso state (derived from providers' checkedAt values) with a useMountedIsoTimestamp hook that captures a stable ISO timestamp at mount time, so getProviderUpdateSidebarPillView is called with a fixed reference point.
• Replaces pendingView and dismissAfterExitKey state variables with useRef-backed equivalents, avoiding intermediate re-renders during exit transitions.
• Extracts synchronization and auto-dismiss effects into useProviderUpdateRenderedViewSynchronization and useProviderUpdateAutoDismiss custom hooks in SidebarProviderUpdatePill.tsx.
• Behavioral Change: the pill now evaluates provider updates relative to component mount time rather than the latest provider checkedAt timestamp.

📊 Macroscope summarized bd8657a. 1 file reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted

🗂️ Filtered Issues

No issues evaluated.

[macroscopeapp]

🟡 Medium sidebar/SidebarProviderUpdatePill.tsx:95

On sidebar remount or page reload, recently completed provider updates (succeeded/failed/unchanged) are silently filtered out and never shown to the user. visibleAfterIso is captured at component mount time via useMountedIsoTimestamp, and isRecentTerminalProvider only keeps terminal updates whose finishedAt is after that timestamp. But the providers in the server snapshot may have a finishedAt that is already in the past relative to mount — yet still represents a newly completed update the user hasn't been notified about. The result is the pill never appears for those updates after a remount. Consider deriving the cutoff from the providers' own timestamps (e.g. the latest prior checkedAt) rather than from the component mount clock, so updates that completed before mount are still shown.

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:

In file @apps/web/src/components/sidebar/SidebarProviderUpdatePill.tsx around line 95:

On sidebar remount or page reload, recently completed provider updates (succeeded/failed/unchanged) are silently filtered out and never shown to the user. `visibleAfterIso` is captured at component mount time via `useMountedIsoTimestamp`, and `isRecentTerminalProvider` only keeps terminal updates whose `finishedAt` is after that timestamp. But the providers in the server snapshot may have a `finishedAt` that is already in the past relative to mount — yet still represents a newly completed update the user hasn't been notified about. The result is the pill never appears for those updates after a remount. Consider deriving the cutoff from the providers' own timestamps (e.g. the latest prior `checkedAt`) rather than from the component mount clock, so updates that completed before mount are still shown.