feat(web): choose where pull request links open - #8335
Conversation
Adds Settings → General → "Open pull request links in T3 Code". On (the default) keeps today's behavior: a pull request link in a thread opens in the review panel beside the conversation. Off sends every click to the browser, which is what command-click already did. Model: claude-opus-5. Harness: Claude Code in T3 Code.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Adds a persisted preference for opening pull-request links in the browser while preserving the existing in-app default and modifier-click behavior. The change is localized to link handling and settings plumbing, with backward-compatible defaults and focused tests. Notes:
You can add or adjust custom eligibility rules. Learn more. |
Clicking a pull request link in a thread always opens the review in the right panel, and the only way to get it into a browser is to remember command-click. People who live in their browser for reviews have no way to make that the default.
Adds Settings → General → Open pull request links in T3 Code, a client setting that is on by default (today's behavior, unchanged). Turn it off and every pull request link — in chat, and the pull request number in the sidebar — goes straight to the browser, exactly as command-click already does. The decision lives in
shouldOpenPullRequestExternally, so both the chat link handler and the sidebar handler follow the same rule, and the Pull requests page still opens reviews in panel tabs either way.Mobile taps already open pull request links in the system browser, so nothing changes there.
Model: claude-opus-5. Harness: Claude Code in T3 Code.
Note
Add
openPullRequestLinksInAppsetting to control where PR links openopenPullRequestLinksInAppfield (defaulttrue) toClientSettingsSchemaandClientSettingsPatchin settings.tsshouldOpenPullRequestExternallyin openPullRequestLink.ts to accept anopenInAppparameter; whenfalse, all clicks open externally (meta/ctrl still always open externally)useOpenChangeRequestLinkanduseOpenPrLinkhooks to read the setting viauseClientSettingsand route unmodified clicks accordinglytrue), preserving current in-app behavior; users who opt out via the new toggle will have all unmodified PR link clicks open in the system browserMacroscope summarized e84367c.