Skip to content

feat(web): choose where pull request links open - #8335

Open
D3OXY wants to merge 2 commits into
pingdotgg:mainfrom
D3OXY:d3oxy/pull-request-link-target
Open

feat(web): choose where pull request links open#8335
D3OXY wants to merge 2 commits into
pingdotgg:mainfrom
D3OXY:d3oxy/pull-request-link-target

Conversation

@D3OXY

@D3OXY D3OXY commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Clicking a pull request link in a thread always opens the review in the right panel, and the only way to get it into a browser is to remember command-click. People who live in their browser for reviews have no way to make that the default.

Adds Settings → General → Open pull request links in T3 Code, a client setting that is on by default (today's behavior, unchanged). Turn it off and every pull request link — in chat, and the pull request number in the sidebar — goes straight to the browser, exactly as command-click already does. The decision lives in shouldOpenPullRequestExternally, so both the chat link handler and the sidebar handler follow the same rule, and the Pull requests page still opens reviews in panel tabs either way.

Mobile taps already open pull request links in the system browser, so nothing changes there.

Model: claude-opus-5. Harness: Claude Code in T3 Code.

Note

Add openPullRequestLinksInApp setting to control where PR links open

  • Adds a boolean openPullRequestLinksInApp field (default true) to ClientSettingsSchema and ClientSettingsPatch in settings.ts
  • Updates shouldOpenPullRequestExternally in openPullRequestLink.ts to accept an openInApp parameter; when false, all clicks open externally (meta/ctrl still always open externally)
  • Adds a toggle in Settings → General in SettingsPanels.tsx with reset-to-default support and settings search integration
  • Updates useOpenChangeRequestLink and useOpenPrLink hooks to read the setting via useClientSettings and route unmodified clicks accordingly
  • Behavioral Change: existing users whose stored settings predate this field will decode to the default (true), preserving current in-app behavior; users who opt out via the new toggle will have all unmodified PR link clicks open in the system browser

Macroscope summarized e84367c.

Adds Settings → General → "Open pull request links in T3 Code". On (the
default) keeps today's behavior: a pull request link in a thread opens in the
review panel beside the conversation. Off sends every click to the browser,
which is what command-click already did.

Model: claude-opus-5. Harness: Claude Code in T3 Code.
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6b4d108e-092f-4aa4-9d9e-f8d199729787

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 27, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at e84367c

Macroscope's review found this PR approvable — Adds a persisted preference for opening pull-request links in the browser while preserving the existing in-app default and modifier-click behavior. The change is localized to link handling and settings plumbing, with backward-compatible defaults and focused tests.

Notes:

  • Macroscope's correctness review did not run, so approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant