feat(mcp): target thread launches by project - #8678
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Thread transfer impact
This comment will update automatically after the next completed run. |
6b41e5d to
27d9ea3
Compare
27d9ea3 to
e1994f8
Compare
e1994f8 to
baad86f
Compare
There was a problem hiding this comment.
Effect service conventions review: two import-namespace deviations around the new VcsDriverRegistry dependency. Everything else (environment-based dependency acquisition in make, the updated layer requirement type, ThreadLaunchService consumption, and the test seams) follows the conventions.
Posted via Macroscope — Effect Service Conventions
baad86f to
192e70c
Compare
192e70c to
1f90503
Compare
1f90503 to
b0bd679
Compare
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR adds cross-project thread access and workspace launch workflows, including Git worktree provisioning, setup execution, branch validation, and a new orchestration authorization boundary. It also routes existing thread creation through a materially different launch path, creating broader runtime impact than a small optional API addition. You can add or adjust custom eligibility rules. Learn more. |
c278983 to
1a5ea57
Compare
1a5ea57 to
13bd326
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Bugbot Autofix is ON, but a cloud agent failed to start.
Reviewed by Cursor Bugbot for commit 13bd326. Configure here.

Problem
Creating a project over MCP is incomplete when a new top-level thread cannot be launched there, and existing thread tools can only resolve targets in the caller's current project.
Change
projectIdand typed root, existing-worktree, or new-worktree launch strategies tocreate_threadsandt3_thread_start.ThreadLaunchServiceso provisioning, setup scripts, receipts, provenance, attachments, and idempotency follow the application workflow.Behavior
Omitted project selection keeps the current project. Omitted workspace selection reuses the caller checkout only in that project; another selected project starts at its configured root and never inherits the caller's worktree path. Existing-worktree launches accept canonical or symlink paths only when they resolve to a Git worktree root of the selected repository. Root launches preserve configured repository subdirectory roots, and root/existing-worktree launches never switch branches. Provider/model/runtime settings still inherit from the caller, and runtime/interaction permission ceilings remain enforced. No arbitrary environment selection is accepted.
Validation
ThreadLaunchService, and orchestrator integration covering a recorded cross-project launch.@t3tools/contractsand server targeted typechecks; targeted lint for changed orchestrator MCP and contract files.Dependency
Depends on #8677 for project contracts, persistence plumbing, and
ProjectService-backed selection. It is the upper layer of native stack #8710, whose trunk is the immutableagents/mcp-controls/base-490318a. Cross-project organization remains a coordinated follow-up on the same resolver and is intentionally not implemented here.Implemented by GPT-5.6-Sol via Codex in T3 Code.