[Issue #1374] distinguish SQL NULL from empty values across LOAD, column vectors, and Retina - #1375
Open
gengdy1545 wants to merge 7 commits into
Open
[Issue #1374] distinguish SQL NULL from empty values across LOAD, column vectors, and Retina#1375gengdy1545 wants to merge 7 commits into
gengdy1545 wants to merge 7 commits into
Conversation
gengdy1545
force-pushed
the
fixbug/nulls
branch
from
August 11, 2026 03:26
453b4ab to
28ef403
Compare
gengdy1545
force-pushed
the
fixbug/nulls
branch
from
August 11, 2026 04:26
bb6e9b2 to
4a6d70a
Compare
Collaborator
Author
|
PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Core: only a
nullreference is SQL NULL; empty bytes/strings are empty values. This rule is now consistent end-to-end.checkBytesNulltreats onlynullas NULL (byte[0]is a value);BinaryColumnVectorno longer coerces empty to NULL.\N→ NULL; empty text/binary →""; empty other types → NULL.InsertData/UpdateDatagainisNullto distinguish NULL from empty bytes; server maps to Javanull,MemTableusesaddNull().PrimaryKeyBytes, shared by LOAD and Storage GC.Also (supporting fixes): split BOOLEAN/TINYINT parsing;
split(limit=-1)keeps trailing empties; LOAD rolls back and cleans unpublished files on failure.