Add customer keyspace rollout concurrency settings - #1404
Draft
darwich6 wants to merge 1 commit into
Draft
Conversation
darwich6
force-pushed
the
ahmed/keyspace-max-rollout-cli
branch
from
September 10, 2026 18:48
00343da to
be6d297
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customers cannot currently configure the existing keyspace shard rollout concurrency from the CLI. Add
pscale keyspace update-settings --max-rollout 1..32and--reset-max-rollout, with readback throughkeyspace settings.The vendored API client preserves the difference between an omitted setting, an explicit integer, and JSON
nullfor reset. Human output shows the configured integer, defaulting to 1 when unset; JSON returns the stored nullable value. Settings PATCHes now include only selected groups, avoiding unrelated durability updates on Metal while preserving unspecified flags within VReplication updates. The new flags reject interactive-mode combinations.Related: https://github.com/planetscale/issues/issues/1469. Requires https://github.com/planetscale/api-bb/pull/22013 to be deployed before CLI release.
Validation:
go test ./...,go build -trimpath ./..., andgo vet ./...passed.git diff --checkpassed.