Repository navigation
fix(checkpoint): preserve state on failed saves - #197
Draft
DevChiniwala wants to merge 2 commits into
Draft
DevChiniwala wants to merge 2 commits into
DevChiniwala wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving a checkpoint currently opens the published phase file with
"w". A serialization error, disk write error or interruption after a partial write can therefore destroy the previous resumable checkpoint and leave invalid JSON at its public path.Serialize to a temporary file in the same checkpoint directory, close it, and atomically replace the phase file only after writing succeeds. Clean up the temporary file on failure or interruption while retaining the existing return/logging behavior and checkpoint format. This protects publication of a complete checkpoint; it does not claim power-loss durability.
Validation on Python 3.12:
a1e05f6: both first saves and overwrites, for I/O errors, serialization errors andKeyboardInterrupt.Draft because the repository-prescribed staged integration run requires Anthropic credentials and Spark/Java, which were not available here. Provider/model training and staged integration have not been claimed as passing.
Repository workflow metadata: the patch version is bumped from 1.4.4 to 1.4.5 as required by the source-change version gate.
poetry check --lockand the branch/title/version checks pass locally. Dependencies and the lockfile are unchanged.