Repository navigation
fix(storage): isolate S3 directory downloads and skip folder markers - #198
Draft
DevChiniwala wants to merge 2 commits into
Draft
DevChiniwala wants to merge 2 commits into
DevChiniwala wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S3Helper.download_directory()lists a literal key prefix. Downloadingexports/traintherefore also selects siblings such asexports/train-old/part.parquet, which can silently contaminate the training dataset. Nested S3 folder-marker objects are also written as regular files, so downloading their child parts subsequently fails withFileExistsError.Use a directory-boundary prefix (
exports/train/) for listing and relative paths, and skip folder markers. Keep the public return path, nested file layout, pagination, source-bucket selection, empty-directory errors and AWS error propagation.Validation on Python 3.12.7 with pytest 8.4.2 and boto3/botocore 1.43.123:
a1e05f6: four regression cases fail and four controls pass. Failures demonstrate the incorrect listing prefix, nested marker/file collision and marker-only directory being reported as a successful download.git diff --checkpasses.Draft while the repository-prescribed staged integration run remains unavailable without Anthropic credentials and Spark/Java. Live S3 and staged provider/training integration have not been claimed as passing.
Repository workflow metadata: the patch version is bumped from 1.4.4 to 1.4.5 as required by the source-change version gate.
poetry check --lockand the branch/title/version checks pass locally. Dependencies and the lockfile are unchanged.