Conversation
Behind a Virtual Host Monster clients (e.g. pat-filemanager via plone.restapi's @querystring-search) send the URL path, which is relative to the virtual root. `_pathByRoot` prepended the navigation root or portal path instead, which only works if both roots coincide. Subsites or language folders as virtual root, contexts inside a navigation root and `_vh_` inside-out hosting returned wrong or no results. Use `request.physicalPathFromURL` when virtual hosting is active and the path is not already a physical portal path. See plone/plone.restapi#2023 Assisted-by: Claude Code (claude-opus-5-5)
|
@petschki thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
erral
left a comment
erral
left a comment
There was a problem hiding this comment.
I have tested this in our website, where I installed the new pat-filemanager and it works.
My usecase is a multilingual site with LanguageRootFolders, I don't have the use-case with subpaths (using _vh_XXXXX in the URL).
|
I have configured the site under a path, and it keeps working. Thank you @petschki ! |
4 participants
Behind a Virtual Host Monster clients (e.g.
pat-filemanagervia plone.restapi's@querystring-search) send the URL path, which is relative to the virtual root._pathByRootprepended the navigation root or portal path instead, which only works if both roots coincide. Subsites or language folders as virtual root, contexts inside a navigation root and_vh_inside-out hosting returned wrong or no results.Use
request.physicalPathFromURLwhen virtual hosting is active and the path is not already a physical portal path.See plone/plone.restapi#2023