Conversation
When the user points Kaleido at a browser with path= or BROWSER_PATH and nothing is there, the error only told them to install Chrome. Now it names the path that was tried.
camdecoster
requested changes
Sep 29, 2026
camdecoster
left a comment
camdecoster
left a comment
Contributor
There was a problem hiding this comment.
Looks good! This is helpful update. Could you please make a couple of changes?
|
|
||
| import pytest | ||
| from choreographer.browsers import chromium | ||
| from choreographer.errors import ChromeNotFoundError |
Contributor
There was a problem hiding this comment.
Let's import from the Kaleido errors for this:
Suggested change
| from choreographer.errors import ChromeNotFoundError | |
| from kaleido.errors import ChromeNotFoundError |
| ## Unreleased | ||
|
|
||
| ### Fixed | ||
| - Name the browser path in `ChromeNotFoundError` when it was set with `path=` or `BROWSER_PATH` and points to nothing, instead of only suggesting to install Chrome [[issue #422](https://github.com/plotly/Kaleido/issues/422)] |
Contributor
There was a problem hiding this comment.
Suggested change
| - Name the browser path in `ChromeNotFoundError` when it was set with `path=` or `BROWSER_PATH` and points to nothing, instead of only suggesting to install Chrome [[issue #422](https://github.com/plotly/Kaleido/issues/422)] | |
| - Add the browser path to message in `ChromeNotFoundError` when it was set with `path=` or `BROWSER_PATH` and points to nothing [[#476](https://github.com/plotly/Kaleido/pull/476)] |
…ors, reword changelog
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #422.
With a wrong
BROWSER_PATH(orpath=), Kaleido 1.4.0 raisesChromeNotFoundErrorrather than hanging, but the message only says to install Chrome, which does not help someone who set the path on purpose. The error now starts with the path that was tried, e.g.No browser found at BROWSER_PATH='/nonexistent/chrome'., followed by the existing install hint.Two tests cover
path=andBROWSER_PATH. The env var test hides the downloaded Chrome, since that one takes precedence overBROWSER_PATH. Full suite passes locally on macOS.