feat: add enable_extensions option to control browser extension loading - #303
Conversation
|
Hi @camdecoster, Just wanted to check if you've had a chance to look at this PR. |
|
Thanks for the PR! I'll take a look and follow up. |
camdecoster
left a comment
There was a problem hiding this comment.
This is a nice addition! Could you please make the few suggested changes and add a CHANGELOG entry? With those items addressed, I can approve this PR.
Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>
|
Thank you for the review! I have applied the suggested changes and updated the |
camdecoster
left a comment
There was a problem hiding this comment.
Could you make a couple of more clean up changes? I missed these before.
Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>
|
The changes were so small that I just took care of them. Thanks for your work! |
|
Hi! I was wondering if there are any plans for a new Choreographer release that includes this change. I'd like to start using this feature in the released version. Thanks again for merging the PR! |
|
Hello! There are always plans, but the follow through takes some time. You're right that we need to put out a new release. I'll try to work on it this week or next. Sorry for the delay. |
|
Thanks for the update! That's great to hear. No worries about the delay, and I appreciate you working on the release! |
|
1.4.0 has been released. |
|
Thanks for the update. I've upgraded to 1.4.0 and confirmed that the feature works as expected. |
Closes #302
This PR implements the
enable_extensionsoption issued in #302 to allow disabling browser extensions.Changes
enable_extensions: bool (True by default)argument.