Skip to content

fix: Use correct browser suffixes in constants #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camdecoster merged 1 commit into from
Sep 22, 2026
+7 −9
Merged

fix: Use correct browser suffixes in constants #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/choreographer/browser_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,13 +180,11 @@ def run() -> subprocess.Popen[bytes] | subprocess.Popen[str]: # depends on args
break
except (BrowserClosedError, BrowserFailedError, asyncio.CancelledError) as e:
raise BrowserFailedError(
"The browser seemed to close immediately after starting.",
"You can set the `logging.Logger` level lower to see more output.",
"You may try installing a known working copy of Chrome by running ",
"`$ choreo_get_chrome`."
""
"It may be your browser auto-updated and will now work upon "
"restart. The browser we tried to start is located at "
"The browser seemed to close immediately after starting. "
"You can set the `logging.Logger` level lower to see more output. "
"You may try installing a known working copy of Chrome by running "
"`$ choreo_get_chrome`. It may be your browser auto-updated and will "
"now work upon restart. The browser we tried to start is located at "
f"{self._browser_impl.path}.",
) from e

Expand Down
4 changes: 2 additions & 2 deletions src/choreographer/browsers/_chrome_constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,10 @@
typical_edge_paths = tuple(_p + _edge_suffix for _p in _windows_app_dirs)

_brave_suffix = r"\BraveSoftware\Brave-Browser\Application\brave.exe"
typical_brave_paths = tuple(_p + _edge_suffix for _p in _windows_app_dirs)
typical_brave_paths = tuple(_p + _brave_suffix for _p in _windows_app_dirs)

_vivaldi_suffix = r"\Vivaldi\Application\vivaldi.exe"
typical_vivaldi_paths = tuple(_p + _brave_suffix for _p in _windows_app_dirs)
typical_vivaldi_paths = tuple(_p + _vivaldi_suffix for _p in _windows_app_dirs)

elif platform.system() == "Linux":
typical_chrome_paths = (
Expand Down
Loading