You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Prevent NaNlonShift from crashing hover on maps when xval is undefined. Fixes#7702.
I created this since I saw PR #7709 was abandoned/deleted by its author.
I think that just catching NaN values is a band-aid fix. I looked into why the values are NaN to begin with, and it has to do with the fact that xval and yval aren't getting set when Plotly.Fx.hover is called with pointNumber in the payload. Could you see if there's a way to set xval and yval to the proper value? Additionally, there might be other places where these values need to be set.
I am not a JS developer and not familiar with the plotly.js code at all, so I can only guess: Maybe xval and yval are optional since the coordinates are already part of pointData?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent
NaNlonShiftfrom crashing hover on maps whenxvalis undefined.Fixes #7702.
I created this since I saw PR #7709 was abandoned/deleted by its author.