Fix directional axis automargin anchors - #8090
Open
FistOfMight wants to merge 2 commits into
Open
FistOfMight wants to merge 2 commits into
FistOfMight wants to merge 2 commits into
Conversation
Preserve anchor coordinates when filtering margin directions so enabled right and top margins can grow. Add regression coverage for anchored and free axes, disabled margins, and clipped labels. Refs plotly#8073
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8073.
Preserve axis anchor coordinates when filtering automargin directions.
Disabled margin sizes remain suppressed. This allows enabled margins
to grow correctly and prevents clipped axis labels.
Adds nine regression tests in the Jasmine axes suite. They cover
anchored and free axes, direction changes, and the reported clipping.
Validation:
can relayout insiderangeandinsiderange react to new data.Before — without the fix
After — with the fix