feat: add optional pyomq backend for ZMQ connectors - #281
Merged
Conversation
Add a small backend selector for ZMQ imports so existing PyZMQ behavior remains default while PLUGBOARD_ZMQ_BACKEND=pyomq can use pyomq. Wire the ZMQ channel and proxy through the selector, add the optional plugboard[omq] extra, and cover backend selection plus pyomq socket/proxy smoke paths.
paddor
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
In case pyomq is missing anything, let me know. There's also a known issue around |
# Conflicts: # pyproject.toml # uv.lock
Contributor
|
Hi @paddor - thanks for contributing this. Looks good to me so will get it merged in shortly. |
Contributor
Author
|
Sick! Glad to see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLUGBOARD_ZMQ_BACKENDbackend selector for ZMQ imports.PLUGBOARD_ZMQ_BACKEND=pyomqforZMQChannelandZMQProxy.plugboard[omq]optional extra withpyomq>=0.20.1,<1.Benchmarks:
ZMQChannelover TCP loopback with 2 Python processes, multipart[topic, payload], pickle/unpickle included, best of 5 runs.33.0k msg/s, pyomq145.0k msg/s, about4.4xfaster.32.4k msg/s, pyomq147.1k msg/s, about4.5xfaster.30.0k msg/s, pyomq128.2k msg/s, about4.3xfaster.