Reduce bundle size by compressing conversion tables - #70
Merged
Merged
Conversation
… UTF-8 tables Move U+2016 (0xE28096) and U+00AC (0xC2AC) entries to the alias table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store the UTF-8 to JIS conversion tables in a compressed text format and expand them on the first call to
convert().The tables are expanded lazily only when a conversion is actually needed, rather than at module load time, to avoid unnecessary initialization overhead.
The first encode now has an extra step to expand the tables, but loading is faster because the tables are much smaller, so load + first conversion is faster overall.
For decoding, expanding the tables takes about as long as the previous
init_JIS_TO_UTF8_TABLE()did, even though it now builds both directions at once.Conversion results are unchanged.