Conversation
|
Warning Review limit reached
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 46 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 76 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. The included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (13)
Comment |
|
@coderabbitai review |
|
@codex review |
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa87c9d00a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "session.status", | ||
| "template.status", | ||
| "bansafe.enforcement", | ||
| "bansafe.risk_changed", |
There was a problem hiding this comment.
When bansafe.risk_changed is triggered, the resulting webhook cannot be handled as a known event: it is absent from KNOWN_WEBHOOK_EVENT_TYPES and WebhookPayloadMap, so constructWebhookEvent classifies it as UnknownWebhookEvent and isEvent(event, "bansafe.risk_changed") does not type-check. Add the corresponding webhook event and payload typing alongside exposing this fixture.
Useful? React with 👍 / 👎.
1 participant
Adds the TypeScript SDK for test events on Test numbers (polymorfa/polymorfa#203). Contracts are synced from that PR's branch at
3d20ec3f6d326f74fb6d2e90b92402ccd3b9ac14. This is a coordinated dependency that isn't on monorepodevyet; re-sync to the merge commit before release.MessagingClient.testing.triggerEvent(projectId, { session, event, overrides?, fromSession? })→{ event, session, delivery, eventId, source }MessagingClient.testing.listEventFixtures(projectId)TestEventFixtureand the runtimeTEST_EVENT_FIXTURES(message.received,message.ack,message.failed,call.received,call.missed,call.ended,session.status,template.status,bansafe.enforcement,bansafe.risk_changed). AlsoTestEventOverrides,TriggerTestEventRequest/Response,TestEventFixtureInfo.PolymorfaValidationErrorand the per-project limit asPolymorfaRateLimitError.Contract reconciliation
PublicError/PlatformAccessPublicErrorcodes (connection_limit,call_claimed,call_not_ringing), which the SDK doesn't enumerate. I verified this by recomputing with the old error schemas substituted: the fingerprints then match the previous ledger.devchanged 6 VoIP and 2 project operations (reportedchanged), added 5 Calls operations (ledgermissing, with a reason) and removed 4 VoIP operations (removed). These belong to feat(calls)!: unified call clients, SIP trunks and call settings #262.check:coverage --strictpasses, but the report is not gap-free: 290 covered, 5 missing, 103 excluded, 8 changed.Five-part check
polymorfa triggeron top of these methods.packages/typescript/README.md(Trigger test events),CHANGELOG.md,contracts/README.md. The public Mintlify guide in #203 usesclient.testing.triggerEvent.test-numbersbeta. The SDK method doesn't grant access.Verification
test/testing-events.test.ts(5 tests): request shape and encoding, fixture listing, 400 →PolymorfaValidationError, 429 →PolymorfaRateLimitError, client-token refusal before transport.npm run format:check,lint,typecheck,check:coverage,check:names,build,build:workspaces, andnpm test(74 files, 497 tests). The coverage tests were updated for the new revision and assert that only/messaging/voip/*removals remain unresolved.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.