findings: wasmparser skips case-folding on [method]/[static] names - #237
Merged
Conversation
Recorded while validating #185 against the spec and wasm-tools/wasmtime: Explainer.md's strongly-unique rule folds acronym case before comparing extern names (its own example rejects [method]foo.BAR next to [method]foo.bar), but wasmparser's ResourceFunc derives Eq/Hash on the raw string, so method/static case-collisions validate everywhere our pipeline looks. Candidate bytecodealliance/wasm-tools issue; filing is the operator's call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracker entry only (no code). Found while validating #185 against the component-model spec and wasm-tools/wasmtime.
Explainer.md §Name Uniqueness requires strongly-unique comparison (fold acronym case, strip the
[...]prefix) and explicitly lists[method]foo.BARvs[method]foo.baras a validation error — but wasmparser'sResourceFunccompares the rawa.bstring, so method/static case-collisions validate in wasm-tools 1.247, wasmtime 47, and our translator-shim alike (plain-label and record-field folded collisions are correctly rejected viaKebabStr).Full validation record: #185 (comment)