conformance: wizer-pre-initialize the composed leg's suite - #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes the wizer item from #372, corrected by measurement — the item's premises needed inverting in two places, and the payoff concentrates in one leg:
component-test wizenon thewac plugoutput fails with wasmtime-wizer's "nested components with modules not currently supported". The route that works is the reverse order: wizen the bare suite, then compose. The bare suite'spolymorph:webcrypto/*imports put it past the shipped plain-suite bin, so ct-driver — which already owns exactly the right linker — grows a--wizen <out.wasm>mode callingcomponent_test_runner::wizen::wizen_withwith the same store data and full-supportLinkOptionsits run path uses (thewizercargo feature on component-test-runner; wasmtime-wizer 47 matches the tree's wasmtime 47.0.2).cases_per_instance: 0— instance-per-worker — so the enumeration tax wizer removes is already amortized there (measured: the full shared suite runs in 2.6s locally at--jobs 8; its ~50s on CI is phase contention). They are deliberately left unchanged.--jobs 8), 27.8s → 11.9s wall and 197.9s → 73.3s total CPU (~2.6x); on the CPU-bound 4-vCPU runner the leg's demand drops proportionally, which should take it off the critical path and return the freed share to the other legs. The residual per-case cost is the census handle lift, which is the price of the isolation and stays.The wizen step runs inside
run-composed(0.2s locally):ct-driver --wizen→wac plugthe wizened suite → ct-runner unchanged.--suite-artifactstill names the canonical bare artifact, so envelope identity, tags scheduling, and the aggregate's lock binding are untouched.Verification: wizened and unwizened composed runs are row-identical including order (19,093 lines,
duration-msstripped);just conformance-ct::allgreen (8 targets / 76,364 results and 7 / 2,316, 0 failing beyond declared expected-fail, 0 validation errors — committed matrices unchanged);just test(20 suites),just fmt-check,just clippypass.Part of #372 (the artifact-cache-key residue item remains; this PR closes out the wizer item with the leg-level corrections above recorded on the issue).