Follow-ups from the partial-availability round: drifted citations, an unmeasured illustration, one CDP helper instead of three - #116
Merged
Conversation
… an illustration that was never measured, and one CDP helper instead of three - solo.ts's one-sided-reload gap block cites the conn-status latch at its current home (lib.rs:4407 write / :4413-4420 read; the old :3700/:3706 numbers pointed into Gdrive pickup code), and names the filed issue (#113). The three expected-red scenario banners carried the same drifted numbers post-#109 and are corrected too, with #113 in their promotion paragraphs and #115 at relay-partition's 30s-first-tick note; worker-eviction cites #114 at the 120s-hang warning. - locks.ts's 'lock held, lease stale' illustration named a suspended TAB -- but the lease heartbeat is the SharedWorker's, and devstore row 55 measured that the question cannot even be posed in this build (CDP page freeze does not take). The illustration is now worker-true and the unmeasured question is named instead of implied answered. - cdp.ts's killSharedWorker learns title matching (SharedWorkerMatch: urlIncludes/title, exactly-one-match semantics) -- every solo/demo device runs the identical worker script, so only the SharedWorker's NAME (the target's title, pm-device-<id>) can tell two devices' hosts apart. worker-eviction and convergence-soak drop their local copies and import it; the devstore copy stays, deliberately (no import edge into demo/e2e). setWebLifecycleState's hazard comment now also carries row 55's the-override-can-lie finding. Gates: e2e-check, runtime just check, just site, worker-eviction + one-sided-reload(xfail) + harness-faults green, soak green at seeds 1 and 2 (seed 2 exercises the new kill path).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fixes queued during the partial-availability testing round (PR #108), now that its issues are filed (#113, #114, #115):
:4407write /:4413-4420read) and link the filed issues at the natural spots — conn-status is write-once: a dead wire is indistinguishable from a healthy one, so no page path may ever re-dial #113 in the promotion paragraphs, solo: the first tick after a relay death blocks ~30s behind a driver call's own deadline #115 at the 30s-first-tick note, An evicted device host is invisible to its tabs: every RPC hangs to the full 120s client deadline #114 at the 120s-hang warning.cdp.ts:killSharedWorkerlearns title matching ({ urlIncludes?, title? }, exactly-one-match): every device runs the identical worker script, so only the SharedWorker's name (pm-device-<id>, the target's title) distinguishes two devices' hosts. worker-eviction and convergence-soak drop their local copies and import it; the devstore copy stays by design (no import edge into demo/e2e). The freeze helper's hazard comment carries row 55's the-override-can-lie finding.Net −76 lines. Gates:
just e2e-check,runtime just check,just site, worker-eviction + one-sided-reload (xfail) + harness-faults green, soak green at seeds 1 and 2 (seed 2 exercises the new kill path).Automerge armed (merge commit, org convention).