Repository navigation
Ignore inherited object members in variable lookups - #132
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An undefined
$constructorcurrently expands tofunction Object() { [native code] }instead of triggering the undefined-variable error.$toStringsimilarly produces invalid CSS even in silent mode. Theonlyoption also reads inherited object members as variable values.Check own properties before resolving values in both lookup paths. Existing undefined-value handling and explicitly defined names such as
$constructorremain supported; the check also works on the supported Node 14 runtime.Validation:
git diff --checkpass.No dependencies or public API were changed.