refactor(actor)!: Move lifecycle handling into state hooks - #938
Merged
Merged
Conversation
Add initialize and teardown hooks to actor states. Consolidate message-generic handlers under `powerapi.actor` package. Move message dispatching into State and make actor state non-optional. Add `FormulaActor.create_state()` for specialized formula states. BREAKING CHANGE: powerapi.handler and specialized lifecycle handlers have been removed. Handlers must be imported from powerapi.actor, and actor-specific lifecycle must be implemented through `State` hooks.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #938 +/- ##
==========================================
+ Coverage 82.93% 84.28% +1.35%
==========================================
Files 86 81 -5
Lines 2854 2826 -28
==========================================
+ Hits 2367 2382 +15
+ Misses 487 444 -43
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR overview:
initialize()andteardown()lifecycle hooks to actor states.powerapi.actorpackage.State.FormulaActor.create_state()so formula implementations can provide specialized states.BREAKING CHANGES:
powerapi.handlerpackage.InitHandlertoInitializedStateHandler.State.initialize()andState.teardown().create_state()and callsuper().setup()instead of creating state or registering lifecycle handlers themselves.