Repository navigation
refactor(actor)!: Improve actor shutdown and supervisor lifecycle handling - #945
Merged
Merged
Conversation
Make `KubernetesPreProcessorActor` and `OpenStackPreProcessorActor` inherit from `PreProcessorActor` instead of the generic `ProcessorActor`.
Finalize actor state after shutdown, setup failures, and processing errors. Preserve graceful shutdown intent and skip unstarted pollers and monitors. BREAKING CHANGE: Remove `Actor.low_exception`; processing errors now propagate after cleanup.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #945 +/- ##
==========================================
+ Coverage 84.28% 86.73% +2.44%
==========================================
Files 81 81
Lines 2826 2820 -6
==========================================
+ Hits 2382 2446 +64
+ Misses 444 374 -70
🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…rder Clean up failed actor initialization without registering the actor. Stop and join each pipeline stage before stopping downstream stages. BREAKING CHANGE: Removed `start_message` parameter of `launch_actor`. `kill_actors` now waits for stage shutdown.
Use the platform temporary directory for IPC endpoints. Replace serialization wrappers with direct PyZMQ calls.
Always drain pending messages when handling a poison pill. Remove shutdown mode propagation and simplify lifecycle tests. BREAKING CHANGE: Remove `soft` argument from `PoisonPillMessage`, and the `graceful` argument from `ActorProxy.kill`, `State.teadown` and `Supervisor.kill_actors` methods.
gfieni
force-pushed
the
refactor/actor-shutdown-flow
branch
from
October 5, 2026 13:23
121c8f7 to
9bab91a
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR overview:
PreProcessorActor.Breaking changes:
Actor.low_exception; processing errors propagate after cleanup.start_messagefromSupervisor.launch_actor().softfromPoisonPillMessageandgracefulfrom shutdown and state teardown methods.BackendSupervisor.kill_actors()now blocks until stages stop.BackendSupervisor.launch_actor()rejects unsupported actor types.