test: cover dynamically updated closeOnEsc prop - #576
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #576 +/- ##
=======================================
Coverage 80.69% 80.69%
=======================================
Files 7 7
Lines 202 202
Branches 74 74
=======================================
Hits 163 163
Misses 29 29
Partials 10 10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #504.
The bug (a stale
closeOnEscclosure captured by the document keydown listener) shared its root cause with #524 and was fixed in #573: the listener is now registered in an effect that depends oncloseOnEsc, so it always uses the latest prop value.This PR adds regression tests that lock the behavior in:
closeOnEscupdated from true to false while the modal is open does not close on esc.closeOnEscupdated from false to true while the modal is open closes on esc.Both pass on master and fail when the #573 source fix is reverted.