Repository navigation
Conversation
belisoful
marked this pull request as ready for review
November 5, 2026 21:39
Member
Author
|
@ctrlaltca This is good to rebase/squash and merge. This is mostly just adding upsert and insertOrIgnore. If you want to tag this v1.0.1 and release, that would be good for the community but not entirely necessary because Prado v4.4/5 is not released yet; making this tag against a pre-alpha core. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns SqlMap with PRADO's Data layer renovation for 4.4 (pradosoft/prado#1088, merged to
masterasda09515) and keeps this package's fixes. Each file was three-way merged against the 4.4 version; see CHANGELOG[Unreleased].Requirements
"pradosoft/prado": "^4.4@dev"until 4.4 is tagged) and PHP 8.2. The fallbacks for older cores are removed, including the PRADO 4.3 message unquoting inTSqlMapException.Added
<insertOrIgnore>and<upsert>mapping elements (TSqlMapInsertOrIgnore,TSqlMapUpsertwithupdateColumns/conflictColumns,TInsertOrIgnoreMappedStatement,TUpsertMappedStatement). They run throughTSqlMapGateway::insert()with the driver's own conflict SQL. Docs:docs/statements/upsert.md.Changed
dbTypebinds withTDbCommand::getColumnTypeFromValue().sqlmap_limit_offset_unsupported._getZappableSleepProps().TMappedStatement(invokable delegates, case-insensitive column matching, LEFT JOINgroupBy) are kept over v4.4's older code.Tests
TSqlMapUpsertTest(parsing, attributes,selectKey, cache flush) andSqliteUpsertStatementTest(both tags on SQLite).pradosoft/pradomaster: lint, cs-fixer, PHPStan, unit (213), db-sqlite (138).