Skip to content

Mobkoi: do not hardcode bid seat, to support aliases #4549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabrielmougard wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −3
Open

Mobkoi: do not hardcode bid seat, to support aliases #4549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/prebid/server/bidder/mobkoi/MobkoiBidder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ private static List<BidderBid> bidsFromResponse(BidResponse bidResponse) {
.map(SeatBid::getBid)
.filter(Objects::nonNull)
.flatMap(Collection::stream)
.map(bid -> BidderBid.of(bid, BidType.banner, "mobkoi", bidResponse.getCur()))
.map(bid -> BidderBid.of(bid, BidType.banner, bidResponse.getCur()))
.toList();
}
}
6 changes: 4 additions & 2 deletions src/test/java/org/prebid/server/bidder/mobkoi/MobkoiBidderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ public void makeBidsShouldReturnEmptyListIfBidResponseSeatBidIsNull() throws Jso
}

@Test
public void makeBidsShouldReturnBannerBidWithMobkoiSeat() throws JsonProcessingException {
public void makeBidsShouldReturnBannerBidWithoutSeatSoAliasesWork() throws JsonProcessingException {
// given
final BidResponse bannerBidResponse = givenBidResponse(bidBuilder -> bidBuilder.mtype(1).impid("123"));
final BidderCall<BidRequest> httpCall = givenHttpCall(mapper.writeValueAsString(bannerBidResponse));
Expand All @@ -211,7 +211,9 @@ public void makeBidsShouldReturnBannerBidWithMobkoiSeat() throws JsonProcessingE
assertThat(result.getValue())
.containsExactly(
BidderBid.of(
Bid.builder().mtype(1).impid("123").build(), banner, "mobkoi", "USD"));
Bid.builder().mtype(1).impid("123").build(), banner, "USD"));
assertThat(result.getValue()).allSatisfy(bidderBid ->
assertThat(bidderBid.getSeat()).isNull());
Comment on lines +215 to +216

@CTMBNara CTMBNara Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this test. It defaults to null

}

private static BidRequest givenBidRequest(UnaryOperator<Imp.ImpBuilder> impModifier) {
Expand Down
Loading