Fix parsing bugs in ClassificationElement, DirectDateTimeElement and IDContainer#115
Open
Mic92 wants to merge 3 commits into
Open
Fix parsing bugs in ClassificationElement, DirectDateTimeElement and IDContainer#115Mic92 wants to merge 3 commits into
Mic92 wants to merge 3 commits into
Conversation
from_etree converted the element text to Decimal, which crashes on alphanumeric classification codes and breaks roundtripping since the value is a code, not a number.
from_etree dropped the time component via .date() even though to_etree serializes with %H:%M:%S, so roundtrips silently lost data. It also swallowed all parse errors and stored an empty string instead of failing in strict mode.
schemeID is optional on ID elements, but add_from_etree accessed the attribute directly and raised KeyError when parsing documents without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did some fuzzing:
Each fix comes with a regression test.