Skip to content

Bloom and tonemapping fixes - #244

Merged
catilac merged 2 commits into
processing:mainfrom
tychedelia:bloom-fixes
Sep 29, 2026
Merged

catilac merged 2 commits into
processing:mainfrom
tychedelia:bloom-fixes

Conversation

@tychedelia

Copy link
Copy Markdown
Member

Bloom was enabled by default in Python and was also inserting a tonemapper by default.

We want to make users choose tonemapping explicitly as opt-in, as any kind of tonemapper will shift colors from what they may have written on the CPU (i.e. breaking pixel readback).

@tychedelia
tychedelia requested a review from catilac September 27, 2026 01:29
@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Visual regression: 25 changed of 43 cases

case status detail
rectangle ❌ changed 99.96% of pixels differ
py_animated_mesh ❌ changed 99.83% of pixels differ
py_background_image ❌ changed 100% of pixels differ
py_box ❌ changed 99.63% of pixels differ
py_curves ❌ changed 99.69% of pixels differ
py_feedback ❌ changed 1.47% of pixels differ
py_flocking ❌ changed 1.48% of pixels differ
py_geometry_methods ❌ changed 99.87% of pixels differ
py_gltf_load ❌ changed 1.56% of pixels differ
py_lights ❌ changed 92.37% of pixels differ
py_materials ❌ changed 1.09% of pixels differ
py_multi_window ❌ changed 2.16% of pixels differ
py_particles_gpu_surface ❌ changed 17.33% of pixels differ
py_particles_gpu_surface_lit ❌ changed 16.43% of pixels differ
py_particles_lines ❌ changed 2.88% of pixels differ
py_particles_lissajous ❌ changed 98.31% of pixels differ
py_particles_points ❌ changed 24.02% of pixels differ
py_particles_sphere ❌ changed 18.56% of pixels differ
py_particles_surface ❌ changed 16.24% of pixels differ
py_primitives_2d ❌ changed 97.84% of pixels differ
py_rectangle ❌ changed 99.92% of pixels differ
py_shapes ❌ changed 99.62% of pixels differ
py_style_stack ❌ changed 99.64% of pixels differ
py_text ❌ changed 14.64% of pixels differ
py_window_controls ❌ changed 24.1% of pixels differ

Changes accepted by the deliberate-rendering-change label.

baseline ad938a8bdd · adapter llvmpipe (LLVM 20.1.2, 256 bits) (Vulkan, Mesa 25.2.8-0ubuntu0.24.04.2 (LLVM 20.1.2))

Open the visual report · workflow run

@catilac

catilac commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

@tychedelia when running the python examples on macOS I'm getting errors having to do with x11
Edit: broken on main, too

@catilac catilac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming the tests are passing on the CI. but I'd love to be able to run this locally!

@catilac
catilac merged commit 961661a into processing:main Sep 29, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants